[openstack-dev] [Mistral] Cleaning up configuration settings

Renat Akhmerov rakhmerov at mirantis.com
Wed Jun 18 04:56:21 UTC 2014


Ooh, alright :) It passed by me why I was off.

Renat Akhmerov
@ Mirantis Inc.



On 18 Jun 2014, at 01:20, W Chan <m4d.coder at gmail.com> wrote:

> I figured.  I implemented it in https://review.openstack.org/#/c/97684/.
> 
> 
> On Mon, Jun 16, 2014 at 9:35 PM, Renat Akhmerov <rakhmerov at mirantis.com> wrote:
> I don’t think we have them. You can write them I think as a part of what you’re doing.
> 
> Renat Akhmerov
> @ Mirantis Inc.
> 
> 
> 
> On 31 May 2014, at 04:26, W Chan <m4d.coder at gmail.com> wrote:
> 
>> Is there an existing unit test for testing enabling keystone middleware in pecan (setting cfg.CONF.pecan.auth_enable = True)?  I don't seem to find one.  If there's one, it's not obvious.  Can someone kindly point me to it?
>> 
>> 
>> On Wed, May 28, 2014 at 9:53 AM, W Chan <m4d.coder at gmail.com> wrote:
>> Thanks for following up.  I will publish this change as a separate patch from my current config cleanup.
>> 
>> 
>> On Wed, May 28, 2014 at 2:38 AM, Renat Akhmerov <rakhmerov at mirantis.com> wrote:
>> 
>> On 28 May 2014, at 13:51, Angus Salkeld <angus.salkeld at RACKSPACE.COM> wrote:
>> 
>> > -----BEGIN PGP SIGNED MESSAGE-----
>> > Hash: SHA1
>> >
>> > On 17/05/14 02:48, W Chan wrote:
>> >> Regarding config opts for keystone, the keystoneclient middleware already
>> >> registers the opts at
>> >> https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/middleware/auth_token.py#L325
>> >> under a keystone_authtoken group in the config file.  Currently, Mistral
>> >> registers the opts again at
>> >> https://github.com/stackforge/mistral/blob/master/mistral/config.py#L108 under a
>> >> different configuration group.  Should we remove the duplicate from Mistral and
>> >> refactor the reference to keystone configurations to the keystone_authtoken
>> >> group?  This seems more consistent.
>> >
>> > I think that is the only thing that makes sense. Seems like a bug
>> > waiting to happen having the same options registered twice.
>> >
>> > If some user used to other projects comes and configures
>> > "keystone_authtoken" then will their config take effect?
>> > (how much confusion will that generate)..
>> >
>> > I'd suggest just using the one that is registered keystoneclient.
>> 
>> Ok, I had a feeling it was needed for some reason. But after having another look at this I think this is really a bug. Let’s do it.
>> 
>> Thanks guys
>> _______________________________________________
>> OpenStack-dev mailing list
>> OpenStack-dev at lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>> 
>> 
>> _______________________________________________
>> OpenStack-dev mailing list
>> OpenStack-dev at lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 
> 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 
> 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140618/24e0703e/attachment.html>


More information about the OpenStack-dev mailing list