[openstack-dev] [TripleO] Reviews - we need your help!

Tomas Sedovic tsedovic at redhat.com
Thu Jun 12 18:02:43 UTC 2014


On 12/06/14 16:02, Macdonald-Wallace, Matthew wrote:
> FWIW, I’ve tried to make a useful dashboard for this using Sean Dague’s
> gerrit-dash-creator [0].
> 
>  
> 
> Short URL is http://bit.ly/1l4DLFS long url is:
> 
>  
> 
> https://review.openstack.org/#/dashboard/?foreach=%28project%3Aopenstack%2Ftripleo-incubator+OR+project%3Aopenstack%2Ftripleo-image-elements+OR+project%3Aopenstack%2Ftripleo-heat-templates+OR+project%3Aopenstack%2Ftripleo-specs+OR+project%3Aopenstack%2Fos-apply-config+OR+project%3Aopenstack%2Fos-collect-config+OR+project%3Aopenstack%2Fos-refresh-config+OR+project%3Aopenstack%2Fdiskimage-builder%29+NOT+owner%3Aself+NOT+label%3AWorkflow%3C%3D-1+label%3AVerified%3E%3D1%252cjenkins+NOT+label%3ACode-Review%3E%3D-2%252cself+branch%3Amaster+status%3Aopen&title=TripleO+Reviews&Your+are+a+reviewer%2C+but+haven%27t+voted+in+the+current+revision=reviewer%3Aself&Passed+Jenkins%2C+No+Negative+Feedback=NOT+label%3ACode-Review%3C%3D-1+limit%3A100&Changes+with+no+code+review+in+the+last+48hrs=NOT+label%3ACode-Review%3C%3D2+age%3A48h&Changes+with+no+code+review+in+the+last+5+days=NOT+label%3ACode-Review%3C%3D2+age%3A5d&Changes+with+no+code+review+in+the+last+7+days=NOT+label%3ACode-Review%!
 3C%3D2+age
%3A7d&Some+adjustment+required+%28-1+only%29=label%3ACode-Review%3D-1+NOT+label%3ACode-Review%3D-2+limit%3A100&Dead+Specs+%28-2%29=label%3ACode-Review%3C%3D-2
> 
>  
> 
> I’ll add it to my fork and submit a PR if people think it useful.

I was about to mention this, too. The gerrit-dash-creator is fantastic.

This one is missing the Tuskar-related projects (openstack/tuskar,
openstack/tuskar-ui and openstack/python-tuskarclient) and also
openstack/os-cloud-config, though.


> 
>  
> 
> Matt
> 
>  
> 
> [0] https://github.com/sdague/gerrit-dash-creator
> 
>  
> 
> *From:*James Polley [mailto:jp at jamezpolley.com]
> *Sent:* 12 June 2014 06:08
> *To:* OpenStack Development Mailing List (not for usage questions)
> *Subject:* [openstack-dev] [TripleO] Reviews - we need your help!
> 
>  
> 
> During yesterday's IRC meeting, we realized that our review stats are
> starting to slip again.
> 
> Just after summit, our stats were starting to improve. In the 2014-05-20
> meeting, the TripleO  "Stats since the last revision without -1 or
> -2"[1] looked like this:
> 
> 1rd quartile wait time: 1 days, 1 hours, 11 minutes
> 
> Median wait time: 6 days, 9 hours, 49 minutes
> 
> 3rd quartile wait time: 13 days, 5 hours, 46 minutes
> 
>  
> 
> As of yesterdays meeting, we have:
> 
> 1rd quartile wait time: 4 days, 23 hours, 19 minutes
> 
> Median wait time: 7 days, 22 hours, 8 minutes
> 
> 3rd quartile wait time: 13 days, 19 hours, 17 minutes
> 
>  
> 
> This really hurts our velocity, and is especially hard on people making
> their first commit, as it can take them almost a full work week before
> they even get their first feedback.
> 
> To get things moving, we need everyone to make a special effort to do a
> few reviews every day. It would be most helpful if you can look for
> older reviews without a -1 or -2 and help those reviews get over the line.
> 
> If you find reviews that are just waiting for a simple fix - typo or
> syntax fixes, simple code fixes, or a simple rebase - it would be even
> more helpful if you could take a few minutes to make those patches,
> rather than just leaving the review waiting for the attention of the
> original submitter.
> 
> Please keep in mind that these stats are based on all of our projects,
> not just tripleo-incubator. To save you heading to the wiki, here's a
> handy link that shows you all open code reviews in all our projects:
> 
> bit.ly/1hQco1N <http://bit.ly/1hQco1N>
> 
> If you'd prefer the long version:
> https://review.openstack.org/#/q/status:open+%28project:openstack/tripleo-incubator+OR+project:openstack/tuskar+OR+project:openstack/tuskar-ui+OR+project:openstack-infra/tripleo-ci+OR+project:openstack/os-apply-config+OR+project:openstack/os-collect-config+OR+project:openstack/os-refresh-config+OR+project:openstack/os-cloud-config+OR+project:openstack/tripleo-image-elements+OR+project:openstack/tripleo-heat-templates+OR+project:openstack/diskimage-builder+OR+project:openstack/python-tuskarclient+OR+project:openstack/tripleo-specs%29,n,z
> <https://review.openstack.org/#/q/status:open+%28project:openstack/tripleo-incubator+OR+project:openstack/tuskar+OR+project:openstack/tuskar-ui+OR+project:openstack-infra/tripleo-ci+OR+project:openstack/os-apply-config+OR+project:openstack/os-collect-config+OR+project:openstack/os-refr>
> 
> 
> https://wiki.openstack.org/wiki/TripleO#Bug_Triage has links to reviews
> for individual projects as well as more information about how we triage
> bugs.
> 
> [1] http://www.nemebean.com/reviewstats/tripleo-open.html
> 
> 
> 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 




More information about the OpenStack-dev mailing list