[openstack-dev] [Ironic] July Reviewer review

Devananda van der Veen devananda.vdv at gmail.com
Fri Jul 11 22:49:44 UTC 2014


Hi all!

I skipped looking at our review stats last month - sorry about that. I'll
try to do this more consistently at the beginning of each month, even if
there's not much change.

We're about at the middle of the cycle anyway, so now is a really good time
to look back and see how the team activity has changed since the
summit. Regarding
the project's overall pace, compared to my last summary at end of May, I
think there's been a noticeable improvement in review quality and pace. On
the other hand, we've had a lot of specs proposed, and there was very
little movement to review them for about a month, which frustrated some
developers. I think there was good activity last week on spec reviews, but
we could use more volunteers for that moving forward. Ping me if you're
interested.

Some highlights:
- our average patches-per-changeset has gone down by 20% (4.2 -> 3.4),
while the average new changesets-per-day has gone up (5.1 -> 6.3). I would
like to think this is because the specs process is helping to improve the
quality of our code submissions, and because we all spent some time
focusing on improving stability and maintainability of the codebase.
- we've merged almost 50% more changes in the last month than we did in May.

Also, I'm delighted to say that I think a few people are ready to join the
core review team.
I'm starting a separate thread for each change, but the short version is
I'd like to propose the following change:
+ jroll
+ Shrews
- romcheg

The current team roster can be found here:
https://review.openstack.org/#/admin/groups/165


Without further ado, here are the 30 and 60 day stats, truncated at the
one-review-per-day water mark.


Reviews for the last 30 days in ironic
** -- ironic-core team member
+--------------------------+---------------------------------------+----------------+
|         Reviewer         | Reviews   -2  -1  +1  +2  +A    +/- % |
Disagreements* |
+--------------------------+---------------------------------------+----------------+
|         rloo **          |     105   20  43   2  40  11    40.0% |    6 (
 5.7%)  |
|      lucasagomes **      |     100    1  50   4  45  13    49.0% |    4 (
 4.0%)  |
|           mrda           |      90    0  13  77   0   0    85.6% |   21 (
23.3%)  |
|       devananda **       |      68    9  20   4  35  16    57.4% |    5 (
 7.4%)  |
|       dtantsur **        |      62    2  19   1  40  18    66.1% |    6 (
 9.7%)  |
|       YuikoTakada        |      58    0  10  48   0   0    82.8% |   14 (
24.1%)  |
|         whaom **         |      53    0  10  17  26   6    81.1% |   14 (
26.4%)  |
|         dshrews          |      49    0  12  37   0   0    75.5% |    9 (
18.4%)  |
|    jimrollenhagen        |      47    0  11  21  15   8    76.6% |    6 (
12.8%)  |
|       nobodycam **       |      45    1  15   2  27   5    64.4% |    4 (
 8.9%)  |
|        ghe.rivero        |      30    0   4  26   0   0    86.7% |    3 (
10.0%)  |

Total reviews: 898 (29.9/day)
Total reviewers: 47 (avg 0.6 reviews/day)
Total reviews by core team: 531 (17.7/day)
Core team size: 11 (avg 1.6 reviews/day)
New patch sets in the last 30 days: 645 (21.5/day)
Changes involved in the last 30 days: 188 (6.3/day)
  New changes in the last 30 days: 124 (4.1/day)
  Changes merged in the last 30 days: 89 (3.0/day)
  Changes abandoned in the last 30 days: 12 (0.4/day)
  Changes left in state WIP in the last 30 days: 0 (0.0/day)
  Queue growth in the last 30 days: 23 (0.8/day)
  Average number of patches per changeset: 3.4



Reviews for the last 60 days in ironic
** -- ironic-core team member
+--------------------------+---------------------------------------+----------------+
|         Reviewer         | Reviews   -2  -1  +1  +2  +A    +/- % |
Disagreements* |
+--------------------------+---------------------------------------+----------------+
|           mrda           |     257    0  36 221   0   0    86.0% |   46 (
17.9%)  |
|      lucasagomes **      |     234    6  91  10 127  32    58.5% |   14 (
 6.0%)  |
|         rloo **          |     180   21  70   3  86  25    49.4% |    8 (
 4.4%)  |
|       dtantsur **        |     177    4  75  29  69  29    55.4% |   18 (
10.2%)  |
|       devananda **       |     131   21  46   6  58  26    48.9% |    8 (
 6.1%)  |
|         whaom **         |     118    0  22  24  72  13    81.4% |   22 (
18.6%)  |
|    jimrollenhagen        |     112    0  26  60  26   9    76.8% |   15 (
13.4%)  |
|       YuikoTakada        |     104    0  17  87   0   0    83.7% |   26 (
25.0%)  |
|         dshrews          |      88    0  13  75   0   0    85.2% |   14 (
15.9%)  |
|        ghe.rivero        |      83    0   7  76   0   0    91.6% |    8 (
 9.6%)  |
|          yuriyz          |      71    0  27   2  42   9    62.0% |    3 (
 4.2%)  |
|       nobodycam **       |      65    1  21   4  39  12    66.2% |    7 (
10.8%)  |

Total reviews: 1976 (32.9/day)
Total reviewers: 54 (avg 0.6 reviews/day)
Total reviews by core team: 1117 (18.6/day)
Core team size: 11 (avg 1.7 reviews/day)
New patch sets in the last 60 days: 1259 (21.0/day)
Changes involved in the last 60 days: 282 (4.7/day)
  New changes in the last 60 days: 221 (3.7/day)
  Changes merged in the last 60 days: 155 (2.6/day)
  Changes abandoned in the last 60 days: 33 (0.6/day)
  Changes left in state WIP in the last 60 days: 0 (0.0/day)
  Queue growth in the last 60 days: 33 (0.6/day)
  Average number of patches per changeset: 4.5



-Devananda
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140711/172bd44e/attachment-0001.html>


More information about the OpenStack-dev mailing list