[openstack-dev] heads up, set -o errexit on devstack - things will fail earlier now

Sean Dague sean at dague.net
Fri Feb 28 15:00:43 UTC 2014


Actually grenade has always run under errexit, devstack just had enough
legacy cruft in it that it took a while to get it to run clean.

	-Sean

On 02/28/2014 09:13 AM, Mauro S M Rodrigues wrote:
> Awesome! thanks for it!
> 
> Btw I guess this will automatically works for grenade, since we use
> devstack to setup X-1 release, am I right? (and it's not a concern for
> the upgrade part since the upgrade-<component> scripts already contain
> errexit trap on the cleanup functions right?)
> 
> -- 
> mauro(sr)
> 
> 
> On 02/27/2014 06:17 PM, Sergey Lukjanov wrote:
>> And a big +1 from me too. It's really useful.
>>
>> On Fri, Feb 28, 2014 at 12:15 AM, Devananda van der Veen
>> <devananda.vdv at gmail.com> wrote:
>>>   Thu, Feb 27, 2014 at 9:34 AM, Ben Nemec <openstack at nemebean.com>
>>> wrote:
>>>> On 2014-02-27 09:23, Daniel P. Berrange wrote:
>>>>> On Thu, Feb 27, 2014 at 08:38:22AM -0500, Sean Dague wrote:
>>>>>> This patch is coming through the gate this morning -
>>>>>> https://review.openstack.org/#/c/71996/
>>>>>>
>>>>>> The point being to actually make devstack stop when it hits an error,
>>>>>> instead of only once these compound to the point where there is no
>>>>>> moving forward and some service call fails. This should
>>>>>> *dramatically*
>>>>>> improve the experience of figuring out a failure in the gate, because
>>>>>> where it fails should be the issue. (It also made us figure out some
>>>>>> wonkiness with stdout buffering, that was making debug difficult).
>>>>>>
>>>>>> This works on all the content that devstack gates against. However,
>>>>>> there are a ton of other paths in devstack, including vendor plugins,
>>>>>> which I'm sure aren't clean enough to run under -o errexit. So if
>>>>>> all of
>>>>>> a sudden things start failing, this may be why. Fortunately you'll be
>>>>>> pointed at the exact point of the fail.
>>>>>
>>>>> This is awesome!
>>>>
>>>> +1!  Thanks Sean and everyone else who was involved with this.
>>>
>>> Another big +1 for this! I've wished for it every time I tried to add
>>> something to devstack and struggled with debugging it.
>>>
>>> -Deva
>>>
>>> _______________________________________________
>>> OpenStack-dev mailing list
>>> OpenStack-dev at lists.openstack.org
>>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>>>
>>
>>
> 
> 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


-- 
Sean Dague
Samsung Research America
sean at dague.net / sean.dague at samsung.com
http://dague.net

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 482 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140228/f4c896da/attachment.pgp>


More information about the OpenStack-dev mailing list