[openstack-dev] [Mistral] Renaming action types

Renat Akhmerov rakhmerov at mirantis.com
Fri Feb 28 09:36:54 UTC 2014


Haah :) Honestly, I don’t like it. “invoke” doesn’t seem to be carrying any useful information here. And “invoke_mistral” looks completely confusing since it’s not clear it’s related with HTTP.

Renat Akhmerov
@ Mirantis Inc.



On 27 Feb 2014, at 23:42, Manas Kelshikar <manas at stackstorm.com> wrote:

> How about ...
> 
> invoke_http & invoke_mistral to fit the verb_noun pattern. 
> 
> 
> On Wed, Feb 26, 2014 at 6:04 AM, Renat Akhmerov <rakhmerov at mirantis.com> wrote:
> Ooh, I was wrong. Sorry. We use dash naming. We have “on-success”, “on-error” and so forth.
> 
> Please let us know if you see other inconsistencies.
> 
> Thanks
> 
> Renat Akhmerov
> @ Mirantis Inc.
> 
> 
> 
> On 26 Feb 2014, at 21:00, Renat Akhmerov <rakhmerov at mirantis.com> wrote:
> 
> > Thanks Jay.
> >
> > Regarding underscore naming. If you meant using underscore naming for “createVM” and “novaURL” then yes, “createVM” is just a task name and it’s a user preference. The same about “novaURL” which will be defined by users. As for keywords, seemingly we follow underscore naming.
> >
> > Renat Akhmerov
> > @ Mirantis Inc.
> >
> >
> >
> > On 26 Feb 2014, at 17:58, Jay Pipes <jaypipes at gmail.com> wrote:
> >
> >> On Wed, 2014-02-26 at 14:38 +0700, Renat Akhmerov wrote:
> >>> Folks,
> >>>
> >>> I’m proposing to rename these two action types REST_API and
> >>> MISTRAL_REST_API to HTTP and MISTRAL_HTTP. Words “REST” and “API”
> >>> don’t look correct to me, if you look at
> >>>
> >>>
> >>> Services:
> >>> Nova:
> >>>   type: REST_API
> >>>   parameters:
> >>>     baseUrl: {$.novaURL}
> >>>   actions:
> >>>     createVM:
> >>>       parameters:
> >>>         url: /servers/{$.vm_id}
> >>>         method: POST
> >>>
> >>> There’s no information about “REST” or “API” here. It’s just a spec
> >>> how to form an HTTP request.
> >>
> >> +1 on HTTP and MISTRAL_HTTP.
> >>
> >> On an unrelated note, would it be possible to use under_score_naming
> >> instead of camelCase naming?
> >>
> >> Best,
> >> -jay
> >>
> >>
> >>
> >> _______________________________________________
> >> OpenStack-dev mailing list
> >> OpenStack-dev at lists.openstack.org
> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
> 
> 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20140228/1054bd5c/attachment.html>


More information about the OpenStack-dev mailing list