[openstack-dev] [nova] why doesn't _rollback_live_migration() always call rollback_live_migration_at_destination()?

Chris Friesen chris.friesen at windriver.com
Tue Feb 25 15:44:46 UTC 2014


On 02/25/2014 05:15 AM, John Garbutt wrote:
> On 24 February 2014 22:14, Chris Friesen <chris.friesen at windriver.com> wrote:


>> What happens if we have a shared-storage instance that we try to migrate and
>> fail and end up rolling back?  Are we going to end up with messed-up
>> networking on the destination host because we never actually cleaned it up?
>
> I had some WIP code up to clean that up, as part as the move to
> conductor, its massively confusing right now.
>
> Looks like a bug to me.
>
> I suspect the real issue is that some parts of:
> self.driver.rollback_live_migration_at_destination(ontext, instance,
>                          network_info, block_device_info)
> Need more information about if there is shared storage being used or not.

What's the timeframe on the move to conductor?

I'm looking at fixing up the resource tracking over a live migration 
(currently we just rely on the audit fixing things up whenever it gets 
around to running) but to make that work properly I need to 
unconditionally run rollback code on the destination.

Chris



More information about the OpenStack-dev mailing list