[openstack-dev] Criteria for giving a -1 in a review

Tom Fifield tom at openstack.org
Fri Aug 22 05:27:29 UTC 2014


On 22/08/14 00:40, Adam Young wrote:
> On 08/21/2014 12:21 PM, Daniel P. Berrange wrote:
>> On Thu, Aug 21, 2014 at 05:05:04PM +0100, Matthew Booth wrote:
>>> "I would prefer that you didn't merge this."
>>>
>>> i.e. The project is better off without it.
>> A bit off topic, but I've never liked this message that gets added
>> as it think it sounds overly negative. It would better written
>> as
>>
>>    "This patch needs further work before it can be merged"
> Excellent.


Clark has helpfully created a patch that would facilitate this change:

https://review.openstack.org/#/c/116176


Regards,


Tom



More information about the OpenStack-dev mailing list