[openstack-dev] [Nova] nova-specs

Jiang, Yunhong yunhong.jiang at intel.com
Wed Apr 16 17:43:14 UTC 2014


> single comment they made was -1 worthy on its own. Often times I will -1
> for a spelling mistake and then make a bunch of other purely-opinion
> comments which don't necessarily need to change.

Do we really want to -1 for spelling mistake in nova-specs? This is really a bad news for non-native speaker like me because I'm really not sensitive to the spelling even after checking again and again. (Of course I can point out any spelling wrong in Chinese very quickly).

The major concern of the -1 on spelling is, seems nova-drive and nova-cores will not check a patch/spec at all if it's -1 already. Thus -1 on spelling will delay the review, especially if the nova-drive member and the author is in different time zone.

Would it be better to -1 mainly for design issue, and comments on spelling error w/o -1? After all, nova-spec is different with a nova patch.

Thanks
--jyh


> 
> --Dan
> 
> 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev



More information about the OpenStack-dev mailing list