[openstack-dev] [nova][libvirt] Should file injection work for boot from volume images?

Thierry Carrez thierry at openstack.org
Mon Sep 23 08:50:43 UTC 2013


Monty Taylor wrote:
> On 09/20/2013 02:47 PM, Michael Still wrote:
>> Before https://review.openstack.org/#/c/46867/ if file injection of a
>> mandatory file fails, nova just silently ignores the failure, which is
>> clearly wrong. However, that review now can't land because its
>> revealed another failure in the file injection code via tempest, which
>> is...
>>
>> Should file injection work for instances which are boot from volume?
>> Now that we actually notice injection failures we're now failing to
>> boot such instances as file injection for them doesn't work.
>>
>> I'm undecided though -- should file injection work for boot from
>> volume at all? Or should we just skip file injection for instances
>> like this? I'd prefer to see us just support config drive and metadata
>> server for these instances, but perhaps I am missing something really
>> important.
> 
> Well, first of all, I think file injection should DIAF everywhere.

+1

> That said, it may be no surprise that I think boot-from-volume should
> just do config drive and metadata.

That sounds like the simplest way to preserve behavior. From what you
said the current behavior is "try, fail and ignore failure" -- having
noop instead is probably the right thing to do for havana.

-- 
Thierry Carrez (ttx)



More information about the OpenStack-dev mailing list