[openstack-dev] stalled bug fixes for vmware driver
Dan Wendlandt
dan at nicira.com
Fri Sep 20 18:02:43 UTC 2013
I think the real problem here is that in Nova there are bug fixes that are
tiny and very important to a particular subset of the user population and
yet have been around for well over a month without getting a single core
review.
Take for example https://review.openstack.org/#/c/40298/ , which fixes an
important snapshot bug for the vmwareapi driver. This was posted well over
a month ago on August 5th. It is a solid patch, is 54 new/changed lines
including unit test enhancements. The commit message clearly shows which
tempest tests it fixes. It has been reviewed by many vmware reviewers with
+1s for a long time, but the patch just keeps having to be rebased as it
sits waiting for core reviewer attention.
To me, the high-level take away is that it is hard to get new contributors
excited about working on Nova when their well-written and well-targeted bug
fixes just sit there, getting no feedback and not moving closer to merging.
The bug above was the developer's first patch to OpenStack and while he
hasn't complained a bit, I think the experience is far from the community
behavior that we need to encourages new, high-quality contributors from
diverse sources. For Nova to succeed in its goals of being a platform
agnostic cloud layer, I think this is something we need a community
strategy to address and I'd love to see it as part of the discussion put
forward by those people nominating themselves as PTL.
Dan
On Fri, Sep 20, 2013 at 7:07 AM, Gary Kotton <gkotton at vmware.com> wrote:
> Hi,
> The following two patches are really important (they are really simple and
> have been around since beginning of August - they are rebased every couple
> of days):-
> - https://review.openstack.org/#/c/40298/ - Tempest snapshot fails
> - https://review.openstack.org/#/c/43994/ - Disk copy fails
> There are a number of patches that we need to base on top of these that
> are high/critical (depending on how one looks at it). They are namely:
> - https://review.openstack.org/#/c/46730/ - flavor root disk sizes are not
> honored
> - https://review.openstack.org/#/c/47503/ - disabling linked clone and
> cacheing of images
> - https://review.openstack.org/#/c/46231/ - VM resize
> Thanks
> Gary
>
> On 9/19/13 11:39 PM, "Shawn Hartsock" <hartsocks at vmware.com> wrote:
>
> >Greetings stackers!
> >
> >A quick mid-week update on the patches we're tracking for Havana-rc1.
> >There was a bug in my vote counting code that I use to query votes. Some
> >of the older patches were getting their votes counted wrong. Tracking the
> >"age" of a submitted patchset (number of days since a patchset was
> >posted) and the revision number helps spot these problems. I try to
> >validate these reports by hand, but I do miss things on occasion. Let me
> >know if I need to add or edit something.
> >
> >Ordered by priority:
> >* High/Critical https://bugs.launchpad.net/bugs/1223709
> >https://review.openstack.org/46027 readiness:ready for core
> >* High/Critical https://bugs.launchpad.net/bugs/1216510
> >https://review.openstack.org/43616 readiness:needs one more +2/approval
> >* High/Critical https://bugs.launchpad.net/bugs/1226211
> >https://review.openstack.org/46789 readiness:ready for core
> >* High/Critical https://bugs.launchpad.net/bugs/1217541
> >https://review.openstack.org/43621 readiness:needs review
> >* High/High https://bugs.launchpad.net/bugs/1187853
> >https://review.openstack.org/45349 readiness:ready for core
> >* Medium/High https://bugs.launchpad.net/bugs/1190515
> >https://review.openstack.org/33100 readiness:ready for core
> >* High https://bugs.launchpad.net/bugs/1184807
> >https://review.openstack.org/40298 readiness:ready for core
> >* High https://bugs.launchpad.net/bugs/1214850
> >https://review.openstack.org/43270 readiness:needs review
> >* High https://bugs.launchpad.net/bugs/1226052
> >https://review.openstack.org/46730 readiness:needs review
> >* High https://bugs.launchpad.net/bugs/1226826
> >https://review.openstack.org/47030 readiness:needs review
> >* High https://bugs.launchpad.net/bugs/1225002
> >https://review.openstack.org/41977 readiness:ready for core
> >* High https://bugs.launchpad.net/bugs/1194018
> >https://review.openstack.org/43641 readiness:ready for core
> >* High https://bugs.launchpad.net/bugs/1171226
> >https://review.openstack.org/43994 readiness:ready for core
> >* Medium https://bugs.launchpad.net/bugs/1183654
> >https://review.openstack.org/45203 readiness:needs revision
> >* Medium https://bugs.launchpad.net/bugs/1223074
> >https://review.openstack.org/45864 readiness:needs review
> >* Medium https://bugs.launchpad.net/bugs/1199954
> >https://review.openstack.org/46231 readiness:needs review
> >* Medium https://bugs.launchpad.net/bugs/1222349
> >https://review.openstack.org/45570 readiness:needs one more +2/approval
> >* Medium https://bugs.launchpad.net/bugs/1216961
> >https://review.openstack.org/43721 readiness:needs one more +2/approval
> >* Medium https://bugs.launchpad.net/bugs/1215352
> >https://review.openstack.org/43268 readiness:needs one more +2/approval
> >* Medium https://bugs.launchpad.net/bugs/1197041
> >https://review.openstack.org/43621 readiness:needs review
> >* Medium https://bugs.launchpad.net/bugs/1222948
> >https://review.openstack.org/46400 readiness:needs revision
> >* Medium https://bugs.launchpad.net/bugs/1226238
> >https://review.openstack.org/46824 readiness:needs review
> >* Medium https://bugs.launchpad.net/bugs/1224479
> >https://review.openstack.org/46277 readiness:ready for core
> >* Medium https://bugs.launchpad.net/bugs/1207064
> >https://review.openstack.org/42024 readiness:needs revision
> >* Medium https://bugs.launchpad.net/bugs/1180044
> >https://review.openstack.org/43270 readiness:needs review
> >* Medium https://bugs.launchpad.net/bugs/1226425
> >https://review.openstack.org/46895 readiness:needs revision
> >* Low https://bugs.launchpad.net/bugs/1215958
> >https://review.openstack.org/43665 readiness:needs review
> >* Low https://bugs.launchpad.net/bugs/1226450
> >https://review.openstack.org/46896 readiness:ready for core
> >
> >--------------------------------------------------------------------------
> >------
> >Ordered by fitness for review:
> >
> >== needs one more +2/approval ==
> >* Medium https://bugs.launchpad.net/bugs/1222349 review:
> >https://review.openstack.org/45570
> > title: 'VMware: datastore_regex is not honoured'
> > votes: +2:1, +1:5, -1:0, -2:0 age: 11 days revision: 4
> >* Medium https://bugs.launchpad.net/bugs/1216961 review:
> >https://review.openstack.org/43721
> > title: 'VMware: exceptions for RetrievePropertiesEx incorrectly
> handled'
> > votes: +2:1, +1:5, -1:0, -2:0 age: 1 days revision: 2
> >* Medium https://bugs.launchpad.net/bugs/1215352 review:
> >https://review.openstack.org/43268
> > title: 'VMware: unable to access VNC console if password is not
> >configured'
> > votes: +2:1, +1:3, -1:0, -2:0 age: 1 days revision: 12
> >* High/Critical https://bugs.launchpad.net/bugs/1216510 review:
> >https://review.openstack.org/43616
> > title: 'VMware: exception when accessing invalid nodename'
> > votes: +2:1, +1:5, -1:0, -2:0 age: 3 days revision: 8
> >
> >== ready for core ==
> >* High/Critical https://bugs.launchpad.net/bugs/1223709 review:
> >https://review.openstack.org/46027
> > title: 'VMware: boot from volume exception'
> > votes: +2:0, +1:5, -1:0, -2:0 age: 1 days revision: 3
> >* High https://bugs.launchpad.net/bugs/1184807 review:
> >https://review.openstack.org/40298
> > title: 'Snapshot failure with VMwareVCDriver'
> > votes: +2:0, +1:5, -1:0, -2:0 age: 1 days revision: 18
> >* High https://bugs.launchpad.net/bugs/1225002 review:
> >https://review.openstack.org/41977
> > title: 'VMware: no VM connectivity when opaque network does not
> match
> >bridge id'
> > votes: +2:0, +1:5, -1:0, -2:0 age: 4 days revision: 5
> >* Low https://bugs.launchpad.net/bugs/1226450 review:
> >https://review.openstack.org/46896
> > title: 'no image cache tests for VMware Hyper'
> > votes: +2:0, +1:4, -1:0, -2:0 age: 2 days revision: 1
> >* Medium https://bugs.launchpad.net/bugs/1224479 review:
> >https://review.openstack.org/46277
> > title: '[vmware] InvalidURL nonnumeric port in read_write_ util
> with
> >ipv6 host'
> > votes: +2:0, +1:4, -1:0, -2:0 age: 7 days revision: 5
> >* Medium/High https://bugs.launchpad.net/bugs/1190515 review:
> >https://review.openstack.org/33100
> > title: 'Incorrect host stats reported by VMWare VCDriver'
> > votes: +2:0, +1:7, -1:0, -2:0 age: 1 days revision: 19
> >* High https://bugs.launchpad.net/bugs/1194018 review:
> >https://review.openstack.org/43641
> > title: 'Can't use vmware distributed virtual switch with nova'
> > votes: +2:0, +1:5, -1:0, -2:0 age: 25 days revision: 14
> >* High/Critical https://bugs.launchpad.net/bugs/1226211 review:
> >https://review.openstack.org/46789
> > title: 'VMware: some API's return only data on the first cluster
> and not
> >the correct cluster'
> > votes: +2:0, +1:7, -1:0, -2:0 age: 3 days revision: 1
> >* High https://bugs.launchpad.net/bugs/1171226 review:
> >https://review.openstack.org/43994
> > title: 'VMwareVCDriver: Sparse disk copy error on spawn'
> > votes: +2:0, +1:5, -1:0, -2:0 age: 1 days revision: 18
> >* High/High https://bugs.launchpad.net/bugs/1187853 review:
> >https://review.openstack.org/45349
> > title: 'VMWAREAPI: Problem with starting Windows instances on ESXi
> 5.1'
> > votes: +2:0, +1:6, -1:0, -2:0 age: 14 days revision: 9
> >
> >== needs review ==
> >* Medium https://bugs.launchpad.net/bugs/1223074 review:
> >https://review.openstack.org/45864
> > title: 'vsphere: Instance with volume attachment stuck with
> DELETING
> >status'
> > votes: +2:0, +1:4, -1:0, -2:0 age: 1 days revision: 4
> >* Medium https://bugs.launchpad.net/bugs/1199954 review:
> >https://review.openstack.org/46231
> > title: 'VCDriver: Failed to resize instance'
> > votes: +2:0, +1:3, -1:0, -2:0 age: 2 days revision: 6
> >* Low https://bugs.launchpad.net/bugs/1215958 review:
> >https://review.openstack.org/43665
> > title: 'vim_util get_dynamic_property propSet need not be set -
> makes
> >vmware driver hard to diagnose'
> > votes: +2:0, +1:3, -1:0, -2:0 age: 11 days revision: 5
> >* High https://bugs.launchpad.net/bugs/1214850 review:
> >https://review.openstack.org/43270
> > title: 'vmware driver selection of vm_folder_ref does not account
> for
> >datastore'
> > votes: +2:0, +1:1, -1:0, -2:0 age: 28 days revision: 1
> >* Medium https://bugs.launchpad.net/bugs/1197041 review:
> >https://review.openstack.org/43621
> > title: 'nova compute crashes if you do not have any hosts in your
> >cluster'
> > votes: +2:0, +1:2, -1:0, -2:0 age: 0 days revision: 5
> >* High https://bugs.launchpad.net/bugs/1226052 review:
> >https://review.openstack.org/46730
> > title: 'VMware: VM creation ignores the size of the flavor root
> disk'
> > votes: +2:0, +1:2, -1:0, -2:0 age: 0 days revision: 7
> >* Medium https://bugs.launchpad.net/bugs/1226238 review:
> >https://review.openstack.org/46824
> > title: 'VMware Driver reports SwitchNotFound when network already
> exists'
> > votes: +2:0, +1:3, -1:0, -2:0 age: 3 days revision: 1
> >* High https://bugs.launchpad.net/bugs/1226826 review:
> >https://review.openstack.org/47030
> > title: 'VMwareVCDriver: detaching volume fails with TypeError'
> > votes: +2:0, +1:4, -1:0, -2:0 age: 1 days revision: 2
> >* Medium https://bugs.launchpad.net/bugs/1180044 review:
> >https://review.openstack.org/43270
> > title: 'nova failures when vCenter has multiple datacenters'
> > votes: +2:0, +1:1, -1:0, -2:0 age: 28 days revision: 1
> >* High/Critical https://bugs.launchpad.net/bugs/1217541 review:
> >https://review.openstack.org/43621
> > title: 'vmwareapi drivers - most summary fields need not be set'
> > votes: +2:0, +1:2, -1:0, -2:0 age: 0 days revision: 5
> >
> >== needs revision ==
> >* Medium https://bugs.launchpad.net/bugs/1183654 review:
> >https://review.openstack.org/45203
> > title: 'vmware code is using deprecated API that may not handle
> >inventories over 100 items properly'
> > votes: +2:0, +1:1, -1:1, -2:0 age: 14 days revision: 2
> >* Medium https://bugs.launchpad.net/bugs/1222948 review:
> >https://review.openstack.org/46400
> > title: 'VMware: booting multiple instances fails if image is not in
> >cache'
> > votes: +2:0, +1:1, -1:2, -2:0 age: 7 days revision: 6
> >* Medium https://bugs.launchpad.net/bugs/1207064 review:
> >https://review.openstack.org/42024
> > title: 'VMWare : Disabling linked clone does not cache images on
> the
> >datastore'
> > votes: +2:0, +1:1, -1:3, -2:0 age: 1 days revision: 11
> >* Medium https://bugs.launchpad.net/bugs/1226425 review:
> >https://review.openstack.org/46895
> > title: 'Problem specifying VMware network name in FlatNetworking'
> > votes: +2:0, +1:2, -1:1, -2:0 age: 2 days revision: 3
> >
> ># Shawn Hartsock
>
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
--
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Dan Wendlandt
Nicira, Inc: www.nicira.com
twitter: danwendlandt
~~~~~~~~~~~~~~~~~~~~~~~~~~~
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20130920/2c6a7103/attachment.html>
More information about the OpenStack-dev
mailing list