[openstack-dev] Swift account auditor duplicated code

Pete Zaitcev zaitcev at redhat.com
Thu Sep 5 20:29:35 UTC 2013


Hi, Guys:

Here's a weird piece of duplicated call to account_audit() in
swift/account/auditor.py:

        for path, device, partition in all_locs:
            self.account_audit(path)
            if time.time() - reported >= 3600:  # once an hour
                self.logger.info(_('Since %(time)s: Account audits: ' ...)
                self.account_audit(path)
                dump_recon_cache({'account_audits_since': reported, ...)
                reported = time.time()

This was apparently caused by Florian's ccb6334c going on top of
Darrell's 3d3ed34f. Is this intentional, and if not, should we be
fixing it?

-- Pete



More information about the OpenStack-dev mailing list