[openstack-dev] Remove vim modelines?

David Ripton dripton at redhat.com
Thu Oct 24 13:37:12 UTC 2013


On 10/24/2013 08:38 AM, Joe Gordon wrote:

> Why remove them?
>
> * Modelines aren't supported by default in debian or ubuntu due to
> security reasons: https://wiki.python.org/moin/Vim
> * Having modelines for vim means if someone wants we should support
> modelines for emacs
> (http://www.gnu.org/software/emacs/manual/html_mono/emacs.html#Specifying-File-Variables)
> etc. as well.  And having a bunch of headers for different editors in
> each file seems like extra overhead.
> * There are other ways of making sure tabstop is set correctly for
> python files, see https://wiki.python.org/moin/Vim.  I am a vIm user
> myself and have never used modelines.
> * We have vim modelines in only 828 out of 1213 python files in nova
> (68%), so if anyone is using modelines today, then it only works 68% of
> the time in nova
> * Why have the same config 828 times for one repo alone?  This violates
> the DRY principle (Don't Repeat Yourself).

Another +1 from a Vim user.  These patches are No Fun to review, so 
anyone who wants these gone, please pitch in.

-- 
David Ripton   Red Hat   dripton at redhat.com



More information about the OpenStack-dev mailing list