[openstack-dev] [reviewstats] approved patches no longer count towards open reviews

Robert Collins robertc at robertcollins.net
Tue Oct 22 20:07:14 UTC 2013


Russell instant-fixed an issue we found in the TripleO meeting this
morning: a patch ( https://review.openstack.org/#/c/52236/ ) was
approved but stalled waiting on a dependency to get fixed and land. We
noticed that patch because it was in the list of 'oldest patches', but
it was entirely non-actionable :).

Now, such patches are not listed at all, and won't contribute to the
statistics for open reviews. This makes sense because their status
isn't a reflection on the project at all : the submitter could rebase
the patch (if it's not a real dependency), or if it is a real
dependency, the dependency status will reflect appropriately (how long
it's been open, has it got reviews etc).

Anyhow, this is just a) thanks Russell! and b) a headsup if you notice
an old review but your stats are better - this is why - approved
reviews are not 'open'.

-Rob

-- 
Robert Collins <rbtcollins at hp.com>
Distinguished Technologist
HP Converged Cloud



More information about the OpenStack-dev mailing list