[openstack-dev] Top Gate Bugs

Robert Collins robertc at robertcollins.net
Wed Nov 20 18:42:58 UTC 2013


I'm putting up a patch now.

On 21 November 2013 07:19, Salvatore Orlando <sorlando at nicira.com> wrote:
> I've noticed that
> https://github.com/openstack/nova/commit/85332012dede96fa6729026c2a90594ea0502ac5
> stores the network client in local.strong_store which is a reference to
> corolocal.local (the class, not the instance).
>
> In Russell's example instead the code accesses local.store which is an
> instance of WeakLocal (inheriting from corolocal.local).
>
> Perhaps then Roman's findings apply to the issue being observed on the gate.
>
> Regards,
> Salvatore
>
>
> On 20 November 2013 18:32, Russell Bryant <rbryant at redhat.com> wrote:
>>
>> On 11/20/2013 12:21 PM, Alex Gaynor wrote:
>> > Nope, you're totally right, corolocal.local is a class, whose instances
>> > are the actual coroutine local storage.
>>
>> But I don't think his example is what is being used.
>>
>> Here is an example using the openstack.common.local module, which is
>> what nova uses for this.  This produces the expected output.
>>
>> http://paste.openstack.org/show/53687/
>>
>>
>> https://git.openstack.org/cgit/openstack/nova/tree/nova/openstack/common/local.py
>>
>> For reference, original example from OP:
>> http://paste.openstack.org/show/53686/
>>
>> --
>> Russell Bryant
>>
>> _______________________________________________
>> OpenStack-dev mailing list
>> OpenStack-dev at lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
Robert Collins <rbtcollins at hp.com>
Distinguished Technologist
HP Converged Cloud



More information about the OpenStack-dev mailing list