+2 Yes, thanks for raising that concern. I did approve a few patches before we had other core reviewers configured, and I think I also may have also approved a .gitignore patch after. I will strictly conform to our two +2 workflow going forward, as I agree that merge policy is a good one. -- Adrian -------- Original message -------- From: Russell Bryant Date:11/18/2013 6:01 AM (GMT-08:00) To: OpenStack Development Mailing List Subject: [openstack-dev] [Solum] code review, 2 +2s? Most projects follow a review rule that a patch needs 2 +2s before being approved. I suggest we do the same for Solum. I bring it up since I've noticed some inconsistency with this so far. Thanks, -- Russell Bryant _______________________________________________ OpenStack-dev mailing list OpenStack-dev at lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20131118/4bac52e8/attachment.html>