[openstack-dev] [nova] Do we have some guidelines for mock, stub, mox when writing unit test?

Mark McLoughlin markmc at redhat.com
Tue Nov 12 21:49:37 UTC 2013


On Tue, 2013-11-12 at 16:42 -0500, Chuck Short wrote:
> 
> Hi
> 
> 
> On Tue, Nov 12, 2013 at 4:24 PM, Mark McLoughlin <markmc at redhat.com>
> wrote:
>         On Tue, 2013-11-12 at 13:11 -0800, Shawn Hartsock wrote:
>         > Maybe we should have some 60% rule... that is: If you change
>         more than
>         > half of a test... you should *probably* rewrite the test in
>         Mock.
>         
>         
>         A rule needs a reasoning attached to it :)
>         
>         Why do we want people to use mock?
>         
>         Is it really for Python3? If so, I assume that means we've
>         ruled out the
>         python3 port of mox? (Ok by me, but would be good to hear why)
>         And, if
>         that's the case, then we should encourage whoever wants to
>         port mox
>         based tests to mock.
>         
> 
> 
> The upstream maintainer is not going to port mox to python3 so we have
> a fork of mox called mox3. Ideally, we would drop the usage of mox in
> favour of mock so we don't have to carry a forked mox.

Isn't that the opposite conclusion you came to here:

http://lists.openstack.org/pipermail/openstack-dev/2013-July/012474.html

i.e. using mox3 results in less code churn?

Mark.





More information about the OpenStack-dev mailing list