[openstack-dev] Bad review patterns

Radomir Dopieralski openstack at sheep.art.pl
Tue Nov 12 08:26:42 UTC 2013

On 11/11/13 23:35, Mark McLoughlin wrote:


> I make a habit of leaving comments in reviews - positive, negative,
> neutral, whatever. If I have something to say which might be useful to
> the author, other reviewers, my future self, whatever ... then I'll say
> it.
> e.g. if I spend 10 minutes looking at one part of a patch, ultimately
> convincing myself that there really is no better approach and the author
> has made the right tradeoffs ... then I'll say it. I'll briefly describe
> the tradeoffs, the other options that I guess the author considered and
> discounted.
> I sometimes feel guilty about this because I know patch authors just
> want their +2 and often don't want to read through my verbiage ... but,
> as you say, this is a dialogue and the dialogue can yield some
> interesting thoughts and ideas.

Reading is not a problem, it's helpful and people do like attention :)
The problem is if you force them to respond by -1'ing the patch, making
them explain themselves every time.

Radomir Dopieralski

More information about the OpenStack-dev mailing list