[openstack-dev] Bad review patterns

Sean Dague sean at dague.net
Fri Nov 8 00:54:25 UTC 2013

On 11/08/2013 01:37 AM, Pedro Roque Marques wrote:
> Radomir,
> An extra issue that i don't believe you've covered so far is about comment ownership. I've just read an email on the list that follows a pattern that i've heard many complaints about:
> 	-1 with a reasonable comment, submitter addresses the comment, reviewer never comes back.
> Reviewers do need to allocate time to come back and follow up on the answers to their comments.
> Perhaps there is an issue with the incentive system. You can earn karma by doing a code review... certainly you want to incentivise developers that help the project by improving the code quality. But if the incentive system allows for "drive by shooting" code reviews that can be a problem.

It's not really an incentive system problem, this is some place where
there are some gerrit limitations (especially when your list of reviewed
code is long). Hopefully once we get a gerrit upgrade we can dashboard
out some new items like that via the new rest API.

I agree that reviewers could be doing better. But definitely also
realize that part of this is just that there is *so* much code to review.

Realize that most core reviewers aren't ignoring or failing to come back
on patches intentionally. There is just *so* much of it. I feel guilty
all the time by how big a review queue I have, but I also need a few
hours a day not doing OpenStack (incredible to believe). This is where
non core reviewers can really help in addressing the first couple of
rounds of review to prune and improve the easy stuff.

We're all in this together,


Sean Dague

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 482 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20131108/06b360c2/attachment.pgp>

More information about the OpenStack-dev mailing list