[openstack-dev] Bad review patterns
philip.day at hp.com
Thu Nov 7 00:21:38 UTC 2013
> Leaving a mark.
> You review a change and see that it is mostly fine, but you feel that since you
> did so much work reviewing it, you should at least find
> *something* wrong. So you find some nitpick and -1 the change just so that
> they know you reviewed it.
> This is quite obvious. Just don't do it. It's OK to spend an hour reviewing
> something, and then leaving no comments on it, because it's simply fine, or
> because we had to means to test someting (see the first pattern).
Another one that comes into this category is adding a -1 which just says "I agree with
the other -1's in here". If you have some additional perspective and can expand on
it then that's fine - otherwise it adds very little and is just review count chasing.
It's an unfortunate consequence of counting and publishing review stats that having
such a measure will inevitable also drive behavour.
More information about the OpenStack-dev