[openstack-dev] [Solum] Dissecting the very first review

Noorul Islam K M noorul at noorul.com
Sat Nov 2 02:03:09 UTC 2013

Clark Boylan <clark.boylan at gmail.com> writes:

> On Fri, Nov 1, 2013 at 6:29 PM, Noorul Islam K M <noorul at noorul.com> wrote:
>> Now we have the first patch [1] merged into the repository using
>> OpenStack review process. I would like to bring into notice some minor
>> issues.
>> First of all I would like to thank [2] Swapnil for fixing the patch.
>> 1. Look at patch set 3 and it changed the Author and also the Committer. I
>>    am not sure how that happened. I have been using gerrit outside of
>>    OpenStack and I never saw something like that.
>> 2. Another strange part is that, the author date is Oct 1, 2013 12:53 PM
>> Also an ideal process for helping with others patch is discussed in [2].
>> Regards,
>> Noorul
>> [1] https://review.openstack.org/#/c/54877/
>> [2] http://www.mail-archive.com/openstack-dev@lists.openstack.org/msg05998.html
>> _______________________________________________
>> OpenStack-dev mailing list
>> OpenStack-dev at lists.openstack.org
>> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> The Author, Committer, and Date are determined by the local git making
> the commit. Gerrit is just displaying what was pushed to it. As a
> reviewer if those items are important you can ask the author of a
> patchset to push a new patchset that includes updated and potentially
> more correct information. This may involve correcting local settings
> (eg system clock) or you can override the values by passing the
> '--author' and '--date' options to `git commit`.

The point I am trying to make is that, these things should be looked
into before the patch gets merged.

Thanks and Regards

More information about the OpenStack-dev mailing list