[openstack-dev] Working on the next patch while the current one in under review - git & gerrit question

Eugene Nikanorov enikanorov at mirantis.com
Mon May 13 10:46:17 UTC 2013


Avishay,

Try making and commiting some changes to your new branch.

As for lbaas_step1, I would ask you again to look at my patch.
It in fact implements what you call "step1" (plus some more).

Thanks,
Eugene.


On Mon, May 13, 2013 at 2:40 PM, Avishay Balderman <AvishayB at radware.com>wrote:

>  Hi****
>
> I followed https://wiki.openstack.org/wiki/GerritWorkflow#Add_dependency**
> **
>
> and got:****
>
> ** **
>
> avishayb at ubuntu:~/quantum$ git fetch
> https://review.openstack.org/openstack/quantum refs/changes/45/28245/9 &&
> git checkout FETCH_HEAD****
>
> From https://review.openstack.org/openstack/quantum****
>
> * branch            refs/changes/45/28245/9 -> FETCH_HEAD****
>
> Note: checking out 'FETCH_HEAD'.****
>
> ** **
>
> You are in 'detached HEAD' state. You can look around, make experimental**
> **
>
> changes and commit them, and you can discard any commits you make in this*
> ***
>
> state without impacting any branches by performing another checkout.****
>
> ** **
>
> If you want to create a new branch to retain commits you create, you may**
> **
>
> do so (now or later) by using -b with the checkout command again. Example:
> ****
>
> ** **
>
>   git checkout -b new_branch_name****
>
> ** **
>
> HEAD is now at d906d80... multi-vendor-support-for-lbaas****
>
> avishayb at ubuntu:~/quantum$ git checkout -b lbaas_step1****
>
> Switched to a new branch 'lbaas_step1'****
>
> avishayb at ubuntu:~/quantum$ git branch --list****
>
> * lbaas_step1****
>
>   master****
>
> avishayb at ubuntu:~/quantum$ git review -R****
>
> remote: Processing changes: refs: 1, done    ****
>
> *To ssh://avishayb@review.openstack.org:29418/openstack/quantum.git*
>
> *! [remote rejected] HEAD ->
> refs/for/master/bp/multi-vendor-support-for-lbaas-step0 (no new changes)*
>
> *error: failed to push some refs to 'ssh://
> avishayb at review.openstack.org:29418/openstack/quantum.git'*
>
> ** **
>
> ** **
>
> ** **
>
> Any idea?****
>
> ** **
>
> Avishay****
>
> ** **
>
> *From:* Eugene Nikanorov [mailto:enikanorov at mirantis.com]
> *Sent:* Monday, May 13, 2013 11:32 AM
> *To:* OpenStack Development Mailing List
> *Subject:* Re: [openstack-dev] Working on the next patch while the
> current one in under review - git & gerrit question****
>
> ** **
>
> Hi Avishay,****
>
> ** **
>
> Before moving forward, make sure you're not duplicating
> https://review.openstack.org/#/c/28289/****
>
> Regarding working on dependent patches please refer to
> https://wiki.openstack.org/wiki/GerritWorkflow section "Add dependency"
> at the bottom.****
>
> ** **
>
> Thanks,****
>
> Eugene.****
>
> ** **
>
> On Mon, May 13, 2013 at 12:10 PM, Avishay Balderman <AvishayB at radware.com>
> wrote:****
>
> Hi
> I have a patch which is under review.
> I want to start and work on the next patch. The next patch is based on the
> one that is still under review.
> What is the best strategy to achieve that? The assumption is that I will
> have to work on both patches on parallel.
>
> Thanks
>
> Avishay
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev****
>
> ** **
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20130513/94984bba/attachment.html>


More information about the OpenStack-dev mailing list