Open Stack

Henry,

Yes, it looks like the Gerrit tests didn't pick this one up. There must be
some passwordless sudo set somewhere where it shouldn't. I'll file a fix
shortly.

Thanks,
Armando

On Fri, May 10, 2013 at 8:34 PM, Henry Gessau <gessau at cisco.com> wrote:

> Not sure if I am the only one affected by this. Can any one else confirm?
>
> I cloned quantum today and kicked off a full-suite unit test. The
> test run stopped mid-stride with prompts for my sudo password. I have
> confirmed that by reversing out the following change, the tests run fine:
>
> >
> > Change subject: Log a warning if dnsmasq version is below the minimum
> required
> > ......................................................................
> >
> >
> > Log a warning if dnsmasq version is below the minimum required
> >
> > It has been noted that older versions of dnsmasq may have unexpected
> > behavior, so this patch introduces a check on dnsmasq version; if
> > the minimum version is not met, a warning is logged. This is less
> > invasive than raising an Exception and abort the dhcp agent, even
> > though this also seems like a perfectly acceptable behavior.
> >
> > Fixes bug 1170793
> >
> > Change-Id: Idd91c3753fb05f223ed0e3c53ad692ee65ea4905
> > ---
> > M etc/quantum/rootwrap.d/dhcp.filters
> > M quantum/agent/dhcp_agent.py
> > M quantum/agent/linux/dhcp.py
> > M quantum/rootwrap/filters.py
> > M quantum/tests/unit/test_linux_dhcp.py
> > 5 files changed, 57 insertions(+), 0 deletions(-)
> >
> > Approvals:
> >   Alex Xu: Looks good to me, but someone else must approve
> >   Jenkins: Verified
> >   Salvatore Orlando: Looks good to me (core reviewer); Approved
> >   enikanorov: Looks good to me, but someone else must approve
> >   garyk: Looks good to me (core reviewer)
> >
> >
> > --
> > To view, visit https://review.openstack.org/28489
> > To unsubscribe, visit https://review.openstack.org/settings
> >
> > Gerrit-MessageType: merged
> > Gerrit-Change-Id: Idd91c3753fb05f223ed0e3c53ad692ee65ea4905
> > Gerrit-PatchSet: 2
> > Gerrit-Project: openstack/quantum
> > Gerrit-Branch: master
> > Gerrit-Owner: Armando Migliaccio <amigliaccio at nicira.com>
> > Gerrit-Reviewer: Alex Xu <xuhj at linux.vnet.ibm.com>
> > Gerrit-Reviewer: Armando Migliaccio <amigliaccio at nicira.com>
> > Gerrit-Reviewer: Dirk Mueller <dirk at dmllr.de>
> > Gerrit-Reviewer: Jenkins
> > Gerrit-Reviewer: Nachi Ueno <nachi at ntti3.com>
> > Gerrit-Reviewer: Paul Michali <pcm at cisco.com>
> > Gerrit-Reviewer: Salvatore Orlando <salv.orlando at gmail.com>
> > Gerrit-Reviewer: enikanorov <enikanorov at mirantis.com>
> > Gerrit-Reviewer: garyk <gkotton at redhat.com>
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20130510/c9515990/attachment.html>