Open Stack

My fault- after 3 +2's and a lot of discussion on the topic at the end of
the day, I asked Brant to approve the patch after jenkins had been shown to
pass, considering it was causing the centos gate to fail... in retrospect,
this obviously had more impact that I expected!

Apologies,

-Dolph


On Fri, May 10, 2013 at 8:29 AM, Russell Bryant <rbryant at redhat.com> wrote:

> On 05/10/2013 09:06 AM, Dan Prince wrote:
> >
> >
> > ----- Original Message -----
> >> From: "Thierry Carrez" <thierry at openstack.org>
> >> To: openstack-dev at lists.openstack.org
> >> Sent: Friday, May 10, 2013 8:28:30 AM
> >> Subject: Re: [openstack-dev] revert keystone eventlet changes?
> >>
> >> Dan Prince wrote:
> >>> We made a change to keystone eventlet last night that seems to have
> ground
> >>> SmokeStack to a halt:
> >>>
> >>> https://review.openstack.org/#/c/28785/
> >>> https://bugs.launchpad.net/keystone/+bug/1178646
> >>>
> >>> Could we get a speedy revert on that patch until we get this figured
> out?
> >>
> >> There is also a comment on the original review that observes the same
> >> failure: https://review.openstack.org/#/c/28737/
> >>
> >> Sounds like it should be reverted ASAP, and we need some tests to cover
> >> that in the gate.
> >>
> >> Dan: any idea why SmokeStack was happy with it on the review ?
> >
> > ttx: From what I can see only patchset 3 ran fine in SmokeStack.
> Patchset 4 did not get a +1 verified (and I didn't get around to approving
> the negative result so it would post a -1).
>
> As a bit of a sidenote, it's a bit bizarre to see the patch approved by
> its author.  It got some +2s earlier on an earlier rev, but the patch
> had changed since then.
>
> --
> Russell Bryant
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20130510/804495f7/attachment.html>