Open Stack

On 05/08/2013 04:00 PM, Russell Bryant wrote:
> On 05/08/2013 02:13 PM, Sheng Bo Hou wrote:
>> Hi Cinder contributors,
>>
>> I would like to be a bit immodest to nominate Vincent Hou, myself as a
>> core contributor for OpenStack Block Storage(Cinder) project.
>>
>> Last October, I began my work in cinder by testing and looking for bugs.
>> Then, by implementing the blueprint and fixing bugs. After that, I
>> started reviewing the patches. I took some screenshots from the
>> Launchpad website, indicating my contribution and how active I am in
>> cinder community. You can find my name in the list of the ranking.
>>
>> Please take a look at the snapshots below. They are why I think I can be
>> qualified core member. I sincerely hope OpenStack Cinder community can
>> take me into consideration for a new core member. Thank you very much.
>>
>> PS:
>> 1. Here are some of the snapshots for the patches I reviewed:
> 
> Screenshots are kind of a bizarre way to do this ... I think links to
> relevant pages would have sufficed.  :-)
> 
> This message prompted me to take a look at who is doing Cinder reviews.
>  I'm not on cinder-core, so I don't really get a vote, but I'll provide
> some commentary anyway.  :-)
> 
> Review numbers aren't the only metric, but they are something.  When I
> look at these things, I'm looking for some indication of how involved
> people are, as well as whether people are putting effort into providing
> good constructive feedback with -1/-2, or if they are just rubber
> stamping things (primarily just +1/+2).
> 
> Dolph Mathews summarized core member criteria *really* well in another
> thread when he said:
> 
>> Ultimately, "core contributor" to me simply means that this person's downvotes on code reviews are consistently well thought out and meaningful, such that an upvote by the same person shows a lot of confidence in the patch.
> 
> I think that is a *great* way to summarize the criteria that should be used.
> 
> The numbers for the last 90 days are here (please correct me if the
> cinder-core members are marked incorrectly)
> 
> The line for the self-nomination here is:
> 
> |     houshengbo    |       54 (0|2|52|0) (96.3%)       |
> 
> 
> ** -- cinder-core team member
> +-------------------+-----------------------------------+
> |      Reviewer     | Reviews (-2|-1|+1|+2) (+/- ratio) |
> +-------------------+-----------------------------------+
> |  john-griffith ** |     307 (13|27|1|266) (87.0%)     |
> |   avishay-il **   |      109 (1|28|46|34) (73.4%)     |
> |  zhiteng-huang ** |       80 (3|14|5|58) (78.8%)      |
> |      rushiagr     |       75 (0|11|64|0) (85.3%)      |
> |     thingee **    |       71 (0|19|8|44) (73.2%)      |
> |  duncan-thomas ** |       66 (0|15|3|48) (77.3%)      |
> |     houshengbo    |       54 (0|2|52|0) (96.3%)       |
> |   kurt-f-martin   |       46 (0|10|36|0) (78.3%)      |
> |      eharney      |       38 (0|7|31|0) (81.6%)       |
> |   oliver-leahy-l  |       26 (0|6|20|0) (76.9%)       |
> |       markmc      |       24 (6|5|2|11) (54.2%)       |
> |     xing-yang     |       23 (0|2|21|0) (91.3%)       |
> |       zulcss      |       22 (1|4|11|6) (77.3%)       |
> |      jsbryant     |       18 (0|1|17|0) (94.4%)       |
> |   walter-boring   |       17 (0|1|16|0) (94.1%)       |
> |      flaper87     |       16 (0|5|11|0) (68.8%)       |
> |        ttx        |       13 (0|0|0|13) (100.0%)      |
> |       apevec      |        12 (2|1|0|9) (75.0%)       |
> |  stephen-mulcahy  |        6 (0|2|4|0) (66.7%)        |
> |      lzy-dev      |        5 (0|4|1|0) (20.0%)        |
> |     corystone     |        5 (0|1|4|0) (80.0%)        |
> |   jerome-gallard  |        5 (0|0|5|0) (100.0%)       |
> |      emilienm     |        5 (0|0|5|0) (100.0%)       |
> |       dtynan      |        4 (0|2|2|0) (50.0%)        |
> |       sdague      |        4 (0|1|3|0) (75.0%)        |
> |      chmouel      |        4 (0|1|3|0) (75.0%)        |
> |      jbresnah     |        4 (0|0|4|0) (100.0%)       |
> |      bswartz      |        4 (0|0|4|0) (100.0%)       |
> |   rconradharris   |        3 (0|1|2|0) (66.7%)        |
> | francis-moorehead |        3 (0|1|2|0) (66.7%)        |
> |    gandelman-a    |        3 (0|1|1|1) (66.7%)        |
> |       dricco      |        3 (0|0|3|0) (100.0%)       |
> |       yugsuo      |        2 (0|0|2|0) (100.0%)       |
> |      mkerrin      |        2 (0|0|2|0) (100.0%)       |
> |      mdegerne     |        2 (0|0|2|0) (100.0%)       |
> |      ldbragst     |        2 (0|0|2|0) (100.0%)       |
> |    alexpilotti    |        2 (0|0|2|0) (100.0%)       |
> |       Liang       |        2 (0|0|2|0) (100.0%)       |
> |      trossman     |         1 (0|1|0|0) (0.0%)        |
> |      ndipanov     |         1 (0|1|0|0) (0.0%)        |
> |       hubcap      |         1 (0|1|0|0) (0.0%)        |
> |    zhangchao010   |        1 (0|0|1|0) (100.0%)       |
> |      treinish     |        1 (0|0|1|0) (100.0%)       |
> |      ronenkat     |        1 (0|0|1|0) (100.0%)       |
> |       neela       |        1 (0|0|1|0) (100.0%)       |
> |      mengqxqx     |        1 (0|0|1|0) (100.0%)       |
> |      maurosr      |        1 (0|0|1|0) (100.0%)       |
> |      locke105     |        1 (0|0|1|0) (100.0%)       |
> |       lauria      |        1 (0|0|1|0) (100.0%)       |
> |      krtaylor     |        1 (0|0|1|0) (100.0%)       |
> |      heut2008     |        1 (0|0|1|0) (100.0%)       |
> |     ewindisch     |        1 (0|0|1|0) (100.0%)       |
> |       esker       |        1 (0|0|1|0) (100.0%)       |
> |   doug-hellmann   |        1 (0|0|1|0) (100.0%)       |
> |       derekh      |        1 (0|0|1|0) (100.0%)       |
> |    cthiel-suse    |        1 (0|0|1|0) (100.0%)       |
> |       blk-u       |        1 (0|0|1|0) (100.0%)       |
> |       arosen      |        1 (0|0|1|0) (100.0%)       |
> |      YangLei      |        1 (0|0|1|0) (100.0%)       |
> |   vishvananda **  |        1 (0|0|0|1) (100.0%)       |
> +-------------------+-----------------------------------+
> 
> Total reviews: 1109
> 
> 

I should have listed cinderclient as well, since that's another review
responsibility for cinder-core:

Reviews for the last 90 days in python-cinderclient
** -- cinder-core team member
+------------------+-----------------------------------+
|     Reviewer     | Reviews (-2|-1|+1|+2) (+/- ratio) |
+------------------+-----------------------------------+
| john-griffith ** |       40 (1|9|0|30) (75.0%)       |
|     rushiagr     |       12 (0|0|12|0) (100.0%)      |
|  avishay-il **   |        8 (0|1|1|6) (87.5%)        |
|    thingee **    |        7 (0|4|0|3) (42.9%)        |
| duncan-thomas ** |        7 (1|0|0|6) (85.7%)        |
|     eharney      |        6 (0|2|4|0) (66.7%)        |
| james-agentultra |        3 (0|0|3|0) (100.0%)       |
| stephen-mulcahy  |        2 (0|0|2|0) (100.0%)       |
|     bswartz      |        2 (0|0|2|0) (100.0%)       |
|     boris-42     |        2 (0|0|2|0) (100.0%)       |
|      markmc      |         1 (0|1|0|0) (0.0%)        |
|      zulcss      |        1 (0|0|1|0) (100.0%)       |
|    xing-yang     |        1 (0|0|1|0) (100.0%)       |
|  walter-boring   |        1 (0|0|1|0) (100.0%)       |
|     stevemar     |        1 (0|0|1|0) (100.0%)       |
|     mkerrin      |        1 (0|0|1|0) (100.0%)       |
|     jbresnah     |        1 (0|0|1|0) (100.0%)       |
|      dtynan      |        1 (0|0|1|0) (100.0%)       |
|      dmllr       |        1 (0|0|1|0) (100.0%)       |
| zhiteng-huang ** |        1 (0|0|0|1) (100.0%)       |
+------------------+-----------------------------------+

Total reviews: 99


-- 
Russell Bryant