[openstack-dev] [Glance] Removing python-sendfile related code from BaseClient

Mark Washenberger mark.washenberger at markwash.net
Sat Jun 29 16:21:43 UTC 2013


Hi Paul,

I'll always cheer when we remove unused code :-)


On Mon, Jun 24, 2013 at 9:58 AM, Paul Bourke <pauldbourke at gmail.com> wrote:

> I'm adding some unit tests for glance/common/client.py as part of
> bug/1115551, and noticed the image_iterator() function
> (
> https://github.com/openstack/glance/blob/master/glance/common/client.py#L568
> )
> returns two non-existent types, SendFileIterator and
> ImageBodyIterator.
>
> It seems there's no code path that goes down this route; would I be
> correct in assuming this is left over from the legacy glanceclient?
>
> I think there's two possible actions - one would be to remove this and
> related code that calls it from do_request.  The other would be to
> restore these iterator classes back, so this functionality would still
> be supported if desired.  Thoughts?
>
> Thanks,
> -Paul
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20130629/a4a0c668/attachment.html>


More information about the OpenStack-dev mailing list