Open Stack

Interesting, thanks for trying that. I think this is the time people
"feel" the most.

It should help set expectations on how long it will take to get your
change into trunk. It seems, on average, to take two weeks.

Hopefully it is useful to spot reviews that are proving tricky to get
in, and they can be given some extra attention.

I agree, its hard to give anyone a goal on this one. We could try
count aggregate time on waiting for a reviewer throughout the life of
the patch, but I am not sure that will be any more useful.

John

On 28 June 2013 03:42, Russell Bryant <rbryant at redhat.com> wrote:
> Greetings,
>
> The key metric I have been using for knowing whether we are keeping up
> with review requests is the average wait time for getting a review.  In
> a previous thread, we set a goal of keeping that under 4 days (at least
> by the end of the week, may be higher after a weekend).  This is
> calculated using the time that the *latest* patch revision was posted.
> We have been keeping up with this (Nova at 3.5 days right now).
>
> I've been getting a lot of complaints this week about review turnaround.
>  It's important to me that we're doing this well, but action needs to be
> based on real data.
>
> One of the theories was that patches are having to be rebased a bunch,
> so they have been waiting longer than the stats say.  True, but by how
> much?  The answer is now in the stats:
>
> http://russellbryant.net/openstack-stats/all-openreviews.html
>
> The results are much better than I was afraid of.  On average across all
> projects, patches waiting for review have an age of just under 14 days
> since they were first posted.  Nova is below average, sitting at an
> average of just over 10 days.  That doesn't seem bad at all, to me.
>
> So, if we have a problem, it's not Nova specific, at least.  It's harder
> to set a goal for this metric since it's not entirely in the hands of
> reviewers like the other one.
>
> Suggestions for additional tweaks welcome.
>
> Thanks,
>
> --
> Russell Bryant
>
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev