On Jun 24, 2013 6:49 PM, "Russell Bryant" <rbryant at redhat.com> wrote: > > On 06/24/2013 08:14 PM, Angus Salkeld wrote: > > On 24/06/13 22:50 +0100, Mark McLoughlin wrote: > >> Hey, > >> > >> Pulling this out of gerrit for discussion. > >> > >> Background is one of my patches to diskimage-builder was -1ed because I > >> terminated the title line of the commit message with a period: > >> > >> https://review.openstack.org/33262 > >> > >> This is actually the exact opposite to what I consider normal practice > >> for git commit messages as I explained in the review and the tripleo > >> wiki page, so I proposed a hacking change here: > >> > >> https://review.openstack.org/33789 > > > > Can't we just agree to not -1 on this issue? This seems like a major > > waste of people resources. This is exactly why we want a consensus, so we can automatically enforce it without using any human resources (at least during the review process). If we say we don't care, someone will come along and care. If we enforce one option, if someone disagrees the gate will tell them they are wrong. > > +100 > > -- > Russell Bryant > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev at lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20130624/896e3049/attachment.html>