[openstack-dev] Termination of the title line of commit messages

Russell Bryant rbryant at redhat.com
Tue Jun 25 01:47:08 UTC 2013


On 06/24/2013 08:14 PM, Angus Salkeld wrote:
> On 24/06/13 22:50 +0100, Mark McLoughlin wrote:
>> Hey,
>>
>> Pulling this out of gerrit for discussion.
>>
>> Background is one of my patches to diskimage-builder was -1ed because I
>> terminated the title line of the commit message with a period:
>>
>>  https://review.openstack.org/33262
>>
>> This is actually the exact opposite to what I consider normal practice
>> for git commit messages as I explained in the review and the tripleo
>> wiki page, so I proposed a hacking change here:
>>
>>  https://review.openstack.org/33789
> 
> Can't we just agree to not -1 on this issue? This seems like a major
> waste of people resources.

+100

-- 
Russell Bryant



More information about the OpenStack-dev mailing list