[openstack-dev] blueprint amqp-rpc-fast-reply-queue code review

Joshua Harlow harlowja at yahoo-inc.com
Fri Feb 15 05:51:07 UTC 2013


I certainly don't want to wait.

Sent from my really tiny device...

On Feb 12, 2013, at 9:38 PM, "Ray Pekowski" <pekowski at gmail.com<mailto:pekowski at gmail.com>> wrote:

The last patch set of this change has been in code review for almost two weeks with the only code review comments being to remove a method from the unit tests that I used for debugging but left in with the call commented out.  This patch set removes that uncalled method.

I don't understand why this RPC code change that provides a 23X RPC call maximum throughput improvement to a cluster of 3 RabbitMQ servers with mirroring enabled, would not get approved?  It takes the maximum throughput from 35 RPC calls/sec to 800 RPC calls/sec.

Do we really want to wait until Havana for this fix?

Thanks,
Ray

On Tue, Feb 12, 2013 at 11:19 PM, Jenkins (Code Review) <review at openstack.org<mailto:review at openstack.org>> wrote:
Jenkins has posted comments on this change.

Change subject: blueprint amqp-rpc-fast-reply-queue
......................................................................


Patch Set 13: Works for me

Build succeeded.

- http://logs.openstack.org/19721/13/check/gate-oslo-incubator-pyflakes/697 : SUCCESS
- http://logs.openstack.org/19721/13/check/gate-oslo-incubator-docs/807 : SUCCESS
- http://logs.openstack.org/19721/13/check/gate-oslo-incubator-pep8/993 : SUCCESS
- http://logs.openstack.org/19721/13/check/gate-oslo-incubator-python26/993 : SUCCESS
- http://logs.openstack.org/19721/13/check/gate-oslo-incubator-python27/993 : SUCCESS

--
To view, visit https://review.openstack.org/19721
To unsubscribe, visit https://review.openstack.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb09a71472866bd3950f58d4f7f45a3181eb40fc
Gerrit-PatchSet: 13
Gerrit-Project: openstack/oslo-incubator
Gerrit-Branch: master
Gerrit-Owner: Raymond Pekowski <pekowski at gmail.com<mailto:pekowski at gmail.com>>
Gerrit-Reviewer: Andrea Rosa <andrea.rosa at hp.com<mailto:andrea.rosa at hp.com>>
Gerrit-Reviewer: Chris Behrens <cbehrens+gerrit at codestud.com<mailto:cbehrens%2Bgerrit at codestud.com>>
Gerrit-Reviewer: Davanum Srinivas (dims) <davanum at gmail.com<mailto:davanum at gmail.com>>
Gerrit-Reviewer: Eric Windisch <eric at cloudscaling.com<mailto:eric at cloudscaling.com>>
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Joshua Harlow <harlowja at yahoo-inc.com<mailto:harlowja at yahoo-inc.com>>
Gerrit-Reviewer: Raymond Pekowski <pekowski at gmail.com<mailto:pekowski at gmail.com>>
Gerrit-Reviewer: Russell Bryant <rbryant at redhat.com<mailto:rbryant at redhat.com>>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20130214/b2900d69/attachment.html>


More information about the OpenStack-dev mailing list