[openstack-dev] [Ceilometer] Supporting Swift Client < 1.7.5

Sandy Walsh sandy.walsh at RACKSPACE.COM
Thu Feb 14 21:44:19 UTC 2013


Hey!

I'm working on getting CM HACKING Compliant and ran into this little gem:
https://github.com/openstack/ceilometer/blob/master/ceilometer/objectstore/swift_middleware.py#L34

There's no easy way to have the correct order of imports and these tests for specific Swift client versions. 

I could disable Hacking checking for this file, but that feels wrong. It could be easier to just not support Swift clients < 1.7.5 

So, which option is best?
1. Drop support for Swift < 1.7.5 in CM?
2. Solicit ideas for crafting an elegant way to make that code Hacking Compliant?
3. Disable Hacking checks for this file?

Thoughts?
-S





More information about the OpenStack-dev mailing list