[openstack-dev] How to make a change in openstack/common

Vishvananda Ishaya vishvananda at gmail.com
Tue Feb 12 05:21:55 UTC 2013


FYI I think i was tracking down the same bug and went with a workaround to remove one layer of join depth. See my note here:

https://review.openstack.org/#/c/21679/4/nova/conductor/manager.py

If we do increase the recurision depth (or make it configurable), We can remove that hack.

Vish

On Feb 10, 2013, at 2:25 PM, "Day, Phil" <philip.day at hp.com> wrote:

> Thanks Michael, I'll give it a go.
> 
> I assume Oslo has its own set of unit tests, etc
> 
> I hope the Oslo change doesn't take to long to get through, as this is a problem is causing us a write a bit of grief
> 
> Phil
> 
> Sent from Samsung Mobile
> 
> 
> 
> -------- Original message --------
> Subject: Re: [openstack-dev] How to make a change in openstack/common
> From: Michael Still <mikal at stillhq.com>
> To: OpenStack Development Mailing List <openstack-dev at lists.openstack.org>
> CC:
> 
> 
> On Mon, Feb 11, 2013 at 8:43 AM, Day, Phil <philip.day at hp.com> wrote:
> 
>> However this is my first time venturing into changing openstack/common – so
>> I’d appreciate some pointers on how to start.   I’m assuming that I start by
>> pushing the change for review against
>> https://github.com/openstack/oslo-incubator – but it’s not clear to me what
>> I then need to do before I can get that change into Nova so I can add the
>> extra parameter to the call from conductor/manager.
> 
> Yep, this is a two step process. First off send off a change against
> openstack/oslo-incubator (the new name for common) with your change.
> It then goes through the standard code review process. Then you need
> to sync the change into nova and send a code review for that as well.
> 
> The sync process is to use update.py from the oslo-incubator
> repository, although you probably only want to sync the module you
> changed.
> 
> Cheers,
> Mikal
> 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev




More information about the OpenStack-dev mailing list