[openstack-dev] [Horizon] "import only module" message and #noqa
gabriel.pettier at cloudwatt.com
Mon Dec 30 15:10:28 UTC 2013
So Tatiana pointed
to me, and from there i went on to read
and i can see valid points for H302, even if it annoy me sometime, if
it's better for reviews, i understand.
Sorry for the noise
On Mon, Dec 30, 2013 at 03:43:03PM +0100, Gabriel pettier wrote:
> Reading horizon's code and recent reviews, i'm under the impression that
> it's a common practice to use #noqa to bypass the "import only modules"
> qa message, i'm unconvinced of the advantages of this policy (i think
> the namespace is often cleaner when one import only the symbols needed
> from the modules), so i think this policy could be removed, by adding
> "H302" to the list of ignored errors in tox.ini.
> This would allow removing a lot of #noqa comments, making for cleaner
> If there are significant advantages to this policy, however, it should
> be made more consistently applied to fix all these imports.
> Gabriel Pettier
> Software Engineer at CloudWatt.com
> 06 85 10 36 34
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
Software Engineer at CloudWatt.com
06 85 10 36 34
More information about the OpenStack-dev