[openstack-dev] [nova] minimum review period for functional changes that break backwards compatibility

Thomas Goirand zigo at debian.org
Mon Dec 30 09:51:30 UTC 2013


On 12/28/2013 11:21 PM, Day, Phil wrote:
> Hi Folks,
> 
>  
> 
> I know it may seem odd to be arguing for slowing down a part of the
> review process, but I’d like to float the idea that there should be a
> minimum review period for patches that change existing functionality in
> a way that isn’t backwards compatible.  
> 
>  
> 
> The specific change that got me thinking about this is
> https://review.openstack.org/#/c/63209/ which changes the default fs
> type from ext3 to ext4.    I agree with the comments in the commit
> message that ext4 is a much better filesystem, and it probably does make
> sense to move to that as the new default at some point, however there
> are some old OS’s that may still be in use that don’t support ext4.  By
> making this change to the default without any significant notification
> period this change has the potential to brake existing images and
> snapshots.  It was already possible to use ext4 via existing
> configuration values, so there was no urgency to this change (and no
> urgency implied in the commit messages, which is neither a bug or
> blueprint).

IMO, switching to ext4 is a very bad idea, because ext4 doesn't support
online resize2fs, while ext3 does, so switching to ext4 is breaking
cloud-init!!!

Thomas




More information about the OpenStack-dev mailing list