[openstack-dev] [Tempest][qa] Adding tags to commit messages
yfried at redhat.com
Tue Dec 24 10:21:16 UTC 2013
----- Original Message -----
> From: "Masayuki Igawa" <masayuki.igawa at gmail.com>
> To: "OpenStack Development Mailing List (not for usage questions)"
> <openstack-dev at lists.openstack.org>
> Sent: Tuesday, December 24, 2013 11:39:46 AM
> Subject: Re: [openstack-dev] [Tempest][qa] Adding tags to commit
> On Tue, Dec 24, 2013 at 6:20 PM, Yair Fried <yfried at redhat.com>
> > ----- Original Message -----
> >> From: "Masayuki Igawa" <masayuki.igawa at gmail.com>
> >> To: "OpenStack Development Mailing List (not for usage questions)"
> >> <openstack-dev at lists.openstack.org>
> >> Sent: Tuesday, December 24, 2013 10:42:39 AM
> >> Subject: Re: [openstack-dev] [Tempest][qa] Adding tags to commit
> >> messages
> >> Hi,
> >> On Tue, Dec 24, 2013 at 3:47 PM, Yair Fried <yfried at redhat.com>
> >> wrote:
> >> > Hi,
> >> > Suggestion: Please consider tagging your Tempest commit messages
> >> > the same way you do your mails in the mailing list
> >> >
> >> > Explanation: Since tempest is a single project testing multiple
> >> > Openstack project we have a very diverse collection of patches
> >> > as
> >> > well as reviewers. Tagging our commit messages will allow us to
> >> > classify patches and thus:
> >> > 1. Allow reviewer to focus on patches related to their area of
> >> > expertise
> >> > 2. Track "trends" in patches - I think we all know that we lack
> >> > in
> >> > Neutron testing for example, but can we assess how many network
> >> > related patches are for awaiting review
> >> > 3. Future automation of flagging "interesting" patches
> >> >
> >> > You can usually tell all of this from reviewing the patch, but
> >> > by
> >> > then - you've spent time on a patch you might not even be
> >> > qualified to review.
> >> > I suggest we tag our patches with, to start with, the components
> >> > we
> >> > are looking to test, and the type of test (sceanrio, api, ...)
> >> > and
> >> > that reviewers should -1 untagged patches.
> >> >
> >> > I think the tagging should be the 2nd line in the message:
> >> >
> >> > ======================================
> >> > Example commit message
> >> >
> >> > [Neutron][Nova][Network][Scenario]
> >> >
> >> > Explanation of how this scenario tests both Neutron and Nova
> >> > Network performance
> >> >
> >> > Chang-id XXXXXXXXXXXXXXXXXXX
> >> > =======================================
> >> >
> >> > I would like this to start immediately but what do you guys
> >> > think?
> >> +1
> >> And, how about do we the tagging about the services in the
> >> subject(1st line)?
> >> For example:
> >> Neutron:Example commit subject
> >> Because the dashboard of the gerrit shows the subject only now.
> >> I think reviewers can find "interesting" patches easily if the
> >> dashboard shows the tags.
> > I just found out you could query search for messages like this:
> > status:open message:[Neutron]
> Oh, really. Thanks!
> But the query of 'status:open message:[Neutron]' only doesn't work
> for me.
> Application Error
> Server Error
> Invalid query: status:open message:[Neutron] line 1:20 no viable
> alternative at character '['
> Is there any way working with the brackets?
Not that I know of - could be a regex sollution?
for now search without brackets, maybe?
> Sorry for silly question..
> >> This is not so strong opinion because some scenario tests may have
> >> several services tags.
> > And you have a limited subject length that's already not enough
> > (for me at least)
> I agree.
Let's change the subject length limitation to ignore tags
> # Maybe, it's too long for the subject if already not enough :)
> >> --
> >> Masayuki Igawa
> >> _______________________________________________
> >> OpenStack-dev mailing list
> >> OpenStack-dev at lists.openstack.org
> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> > _______________________________________________
> > OpenStack-dev mailing list
> > OpenStack-dev at lists.openstack.org
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> Masayuki Igawa
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the OpenStack-dev