[openstack-dev] Process for proposing patches attached to launchpad bugs?

Dolph Mathews dolph.mathews at gmail.com
Sat Dec 21 02:30:46 UTC 2013

On Friday, December 20, 2013, Russell Bryant wrote:

> On 12/20/2013 09:32 AM, Dolph Mathews wrote:
> > In the past, I've been able to get authors of bug fixes attached to
> > Launchpad bugs to sign the CLA and submit the patch through gerrit...
> > although, in one case it took quite a bit of time (and thankfully it
> > wasn't a critical fix or anything).
> >
> > This scenario just came up again (example: [1]), so I'm asking
> > preemptively... what if the author is unwilling / unable in signing the
> > CLA and propose through gerrit, or it's a critical bug fix and waiting
> > on an author to go through the CLA process is undesirable for the
> > community? Obviously that's a bit of a fail on our part, but what's the
> > most appropriate & expedient way to handle it?
> >
> > Can we propose the patch to gerrit ourselves?
> >
> > If so, who should appear as the --author of the commit? Who should
> > appear as Co-Authored-By, especially when the committer helps to evolve
> > the patch evolves further in review?
> >
> > Alternatively, am I going about this all wrong?
> >
> > Thanks!
> >
> > [1]: https://bugs.launchpad.net/keystone/+bug/1198171/comments/8
> It's not your code, so you really can't propose it without them having
> signed the CLA, or propose it as your own.
> Ideally have someone else fix the same bug that hasn't looked at the patch.

This is kind of what I was afraid of :(

> From a quick look, it seems likely that this fix is small and straight
> forward enough that the clean new implementation is going to end up
> looking very similar.  Still, I think it's the right thing to do.

I don't want to pick on this example too much... It's just what promoted my
question today. In another case, the fix was a one line change and there
was no other possible solution (without expanding scope / refactoring).

> --
> Russell Bryant
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org <javascript:;>
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20131220/a0b4c335/attachment.html>

More information about the OpenStack-dev mailing list