[openstack-dev] [nova] Do we have some guidelines for mock, stub, mox when writing unit test?

John Garbutt john at johngarbutt.com
Thu Dec 19 14:51:51 UTC 2013


On 4 December 2013 17:10, Russell Bryant <rbryant at redhat.com> wrote:
> I think option 3 makes the most sense here (pending anyone saying we
> should run away screaming from mox3 for some reason).  It's actually
> what I had been assuming since this thread a while back.
>
> This means that we don't need to *require* that tests get converted if
> you're changing one.  It just gets you bonus imaginary internet points.
>
> Requiring mock for new tests seems fine.  We can grant exceptions in
> specific cases if necessary.  In general, we should be using mock for
> new tests.

I have lost track a bit here.

The above seems like a sane approach. Do we all agree on that now?

Can we add the above text into here:
https://wiki.openstack.org/wiki/ReviewChecklist#Nova_Review_Checklist

John



More information about the OpenStack-dev mailing list