[openstack-dev] [nova][db] Thoughts on making instances.uuid non-nullable?

Shawn Hartsock hartsock at acm.org
Mon Dec 16 17:01:57 UTC 2013

+1 on a migration to make uuid a non-nullable column. I advocated a few
patches back in Havana that make assumptions based on the UUID being
present and unique per instance. If it gets nulled the VMware drivers will
have have breakage and I have no idea how to avoid that reasonably without
the UUID.

On Mon, Dec 16, 2013 at 11:59 AM, Russell Bryant <rbryant at redhat.com> wrote:

> On 12/16/2013 11:45 AM, Matt Riedemann wrote:
> > 1. Add a migration to change instances.uuid to non-nullable. Besides the
> > obvious con of having yet another migration script, this seems the most
> > straight-forward. The instance object class already defines the uuid
> > field as non-nullable, so it's constrained at the objects layer, just
> > not in the DB model.  Plus I don't think we'd ever have a case where
> > instance.uuid is null, right?  Seems like a lot of things would break
> > down if that happened.  With this option I can build on top of it for
> > the DB2 migration support to add the same FKs as the other engines.
> Yeah, having instance.uuid nullable doesn't seem valuable to me, so this
> seems OK.
> --
> Russell Bryant
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

# Shawn.Hartsock - twitter: @hartsock - plus.google.com/+ShawnHartsock
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20131216/7e6f5d44/attachment.html>

More information about the OpenStack-dev mailing list