[openstack-dev] [Nova] All I want for Christmas is one more +2 ...

Russell Bryant rbryant at redhat.com
Thu Dec 12 14:38:29 UTC 2013


On 12/12/2013 09:22 AM, Day, Phil wrote:
> Hi Cores,
> 
>  
> 
> The “Stop, Rescue, and Delete should give guest a chance to shutdown”
> change https://review.openstack.org/#/c/35303/ was approved a couple of
> days ago, but failed to merge because the RPC version had moved on.  
> Its rebased and sitting there with one +2 and a bunch of +1s  -would be
> really nice if it could land before it needs another rebase please ?

Approved.

FWIW, I'm fine with folks approving with a single +2 for cases where a
patch is approved but needed a simple rebase.  This happens pretty
often.  We even have a script that generates a list of patches still
open that were previously approved:

http://russellbryant.net/openstack-stats/nova-openapproved.txt

-- 
Russell Bryant



More information about the OpenStack-dev mailing list