[openstack-dev] [Nova] Frustrations with review wait times
matt.dietz at rackspace.com
Thu Aug 29 18:49:37 UTC 2013
To add to this, the majority of my reviews come out of the period in the
morning before my team's daily standup. I've found that sufficient for
getting some reviews in, and conversely, fights off the tremendous burnout
I used to get when we had review days back in the beginning of the project.
From: Robert Collins <robertc at robertcollins.net>
Reply-To: OpenStack Development Mailing List
<openstack-dev at lists.openstack.org>
Date: Thursday, August 29, 2013 3:25 AM
To: OpenStack Development Mailing List <openstack-dev at lists.openstack.org>
Subject: Re: [openstack-dev] [Nova] Frustrations with review wait times
>On 29 August 2013 17:33, Christopher Yeoh <cbkyeoh at gmail.com> wrote:
>> On Wed, 28 Aug 2013 15:56:33 +0000
>> Joshua Harlow <harlowja at yahoo-inc.com> wrote:
>>> Shrinking that rotation granularity would be reasonable to. Rotate
>>> once every 2 weeks or some other time period still seems useful to me.
>> I wonder if the quality of reviewing would drop if someone was doing it
>> all day long though. IIRC the link that Robert pointed to in another
>> thread seemed to indicate that the ability for someone to pick up bugs
>> reduces significantly if they are doing code reviews continuously.
>Right, it did - 30m or something from memory; so we have an upper
>bound on reviews in a day - review, rest (e.g. hack), review, ...
>Robert Collins <rbtcollins at hp.com>
>HP Converged Cloud
>OpenStack-dev mailing list
>OpenStack-dev at lists.openstack.org
More information about the OpenStack-dev