[openstack-dev] [Nova] Frustrations with review wait times

Russell Bryant rbryant at redhat.com
Tue Aug 27 14:55:03 UTC 2013

On 08/27/2013 10:43 AM, Daniel P. Berrange wrote:
> I tend to focus the bulk of my review activity on the libvirt driver,
> since that's where most of my knowledge is. I've recently done some
> reviews outside this area to help reduce our backlog, but I'm not
> so comfortable approving stuff in many of the general infrastructure
> shared areas since I've not done much work on those areas of code.
> I think Nova is large enough that it (mostly) beyond the scope of any
> one person to know all areas of Nova code well enough todo quality
> reviews. IOW, as we grow the nova-core team further, it may be worth
> adding more reviewers who have strong knowledge of specific areas &
> can focus their review energy in those areas, even if their review
> count will be low when put in the context of nova as a whole.

I'm certainly open to that.

Another way I try to do this unofficially is give certain +1s a whole
lot of weight when I'm looking at a patch.  I do this regularly when
looking over patches to hypervisor drivers I'm not very familiar with.

Another thing we could consider is take this approach more officially.
Oslo has started doing this for its incubator.  A maintainer of a part
of the code not on oslo-core has their +1 treated as a +2 on that code.


Russell Bryant

More information about the OpenStack-dev mailing list