On 08/15/2013 12:12 PM, Robert Collins wrote: > This may interest data-driven types here. > > https://www.ibm.com/developerworks/rational/library/11-proven-practices-for-peer-review/ > > Note specifically the citation of 200-400 lines as the knee of the > review effectiveness curve: that's lower than I thought - I thought 200 > was clearly fine - but no. > > -Rob > > -- > Robert Collins <rbtcollins at hp.com <mailto:rbtcollins at hp.com>> > Distinguished Technologist > HP Converged Cloud > > > _______________________________________________ > OpenStack-dev mailing list > OpenStack-dev at lists.openstack.org > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > Interesting article. I've often pondered this point: > 6. Use checklists And whether it would be worth investing some time enhancing what is already here https://wiki.openstack.org/wiki/ReviewChecklist to help reviewers identify common security related bugs (for example). Not sure if people need / want this type of thing though. - Grant.