Open Stack

On 15/08/13 22:27 +0930, Christopher Yeoh wrote:
>On Thu, Aug 15, 2013 at 9:54 PM, Daniel P. Berrange <berrange at redhat.com>
>wrote:Commit message quality has improved somewhat since I first wrote &
>published
>
>    that page, but there's definitely still scope to improve things further.
>    What
>    it really needs is for more reviewers to push back against badly written
>    commit messages, to nudge authors into the habit of being more verbose in
>    their commits.
>
>
>
>Agreed. There is often "what" and sometimes "why", but not very often
>"how" in commit messages.
>


Something I'd suggest to *reviewers* and *committers* is to never assume
everyone will understand the why just because you do. Not everything
is obvious to everyone so, if there's anything that worths
emphasizing, do it (request it if you're reviewing).

FF

-- 
@flaper87
Flavio Percoco