[openstack-dev] [nova] Change in openstack/nova[master]: Enhance the validation of the quotas update

Jian Hua Geng gengjh at cn.ibm.com
Tue Apr 2 14:44:59 UTC 2013



I'd like you provide your comments on this patch.

I prefer to keep the check in the patch and add "--force" to make it
possible to change the quota like before my patch.

Any thought?


--------------------------------------------------
Best regard,
David Geng
--------------------------------------------------
----- Forwarded by Jian Hua Geng/China/IBM on 04/02/2013 10:38 PM -----
                                                                           
             "Nikola Dipanov                                               
             (Code Review)"                                                
             <review at openstack                                          To 
             .org>                     gengjh at cn.ibm.com                   
                                                                        cc 
             04/02/2013 09:08          Vish Ishaya                         
             PM                        <vishvananda at gmail.com>, "Kevin L.  
                                       Mitchell"                           
                                       <kevin.mitchell at rackspace.com>,     
             Please respond to         "Davanum Srinivas (dims)"           
             ndipanov at redhat.c         <davanum at gmail.com>                 
                    om                                             Subject 
                                       Change in openstack/nova[master]:   
                                       Enhance the validation of the       
                                       quotas update                       
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           
                                                                           




Nikola Dipanov has posted comments on this change.

Change subject: Enhance the validation of the quotas update
......................................................................


Patch Set 2:

Ideally - we should be able to notify users that their quota has been
decreased and that they will not be able to do what they think they might
be able to do without their failing jobs telling them that.

This may not need to be automated, but would be good to let the admin know
that certain tenants/users will be immediately blocked by this action. Some
ideas:

* maybe leave this as is in the patch, but have the api return all the
users this fails for, and add a --force to still make it possible to change
it like before the patch.

* Leave it as is now, but have the api call return the list of immediately
affected users.

All of these would have to wait for H tho.

These are only a few options with pros and cons. I'd bring this up on the
dev list and see what the community thinks.

--
To view, visit https://review.openstack.org/25887
To unsubscribe, visit https://review.openstack.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba3cee0f0d92cf2e6d64bc83830b0091992d1ee9
Gerrit-PatchSet: 2
Gerrit-Project: openstack/nova
Gerrit-Branch: master
Gerrit-Owner: David Geng <gengjh at cn.ibm.com>
Gerrit-Reviewer: Davanum Srinivas (dims) <davanum at gmail.com>
Gerrit-Reviewer: David Geng <gengjh at cn.ibm.com>
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Kevin L. Mitchell <kevin.mitchell at rackspace.com>
Gerrit-Reviewer: Nikola Dipanov <ndipanov at redhat.com>
Gerrit-Reviewer: SmokeStack
Gerrit-Reviewer: Vish Ishaya <vishvananda at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20130402/7550357a/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pic24035.gif
Type: image/gif
Size: 1255 bytes
Desc: not available
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20130402/7550357a/attachment.gif>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ecblank.gif
Type: image/gif
Size: 45 bytes
Desc: not available
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20130402/7550357a/attachment-0001.gif>


More information about the OpenStack-dev mailing list