[openstack-dev] [nova] Compute test issues - nova.tests.compute.test_compute.py

Russell Bryant rbryant at redhat.com
Wed Oct 31 21:26:59 UTC 2012


On 10/31/2012 03:24 PM, Vishvananda Ishaya wrote:
> 
> On Oct 31, 2012, at 5:56 AM, Nikola Đipanov <ndipanov at redhat.com> wrote:
> 
>> My thinking is that we should either have two separate test suites - one
>> that exercises the ComputeManager alone and the other that puts the
>> compute manager api functions to the test, or stick with a single
>> "integration-like" set of tests but *always* make calls to the API side
>> of things and make sure that both rpc and manager calls work as expected.
> 
> We currently have two sets of tests that actually start services and 
> exercise rpc calls between them:
> 
> nova.tests.api.ec2.* (test_cloud and test_cinder_cloud specifically)
> 
> and
> 
> nova.tests.integrated
> 
> IMO rpc methods in test_compute should be stubbed out. If we want to test
> things with actual rpc calls we should probably put them in nova.tests.integrated
> 
> +1 to getting the tests fixed.

I think splitting test_compute into 2 parts makes sense, too (one that's
testing the api side and one that's testing the manager side).

-- 
Russell Bryant



More information about the OpenStack-dev mailing list