Open Stack

It did come up several months back, yep.

I'm against any enforced minimum review time. Much like using "sleep" in your code, it's an arbitrary solution that's always going to be wrong in some cases. I see it this way:

    1. Your core devs should have some level of consideration for each other and should be able to discern a change that deserves more review.
    2. If you don't trust the judgment of every one of your core devs, you've got a problem that a timeout won't help.
    3. Requiring that, say, a typo docs fix, or a version number bump for release have a mandatory "waiting period" only slows down the machinery overall and adds another frustrating barrier for developers and maintainers alike.

If someone approves a patch too quickly, talk to them about it. Let them know you would've liked more time to review that patch and ask them to consider giving it a little more time in the future. Let's not go shoving in more roadblocks. :-)

All the best,

    - Gabriel


> -----Original Message-----
> From: Sean Dague [mailto:sdague at linux.vnet.ibm.com]
> Sent: Tuesday, October 02, 2012 11:17 AM
> To: OpenStack-dev at lists.openstack.org
> Subject: [openstack-dev] minimum review time?
> 
> So I realize the review queue is short right now, but it seems like perhaps we
> should have more than 7 minutes between first code submission and final
> approval for Jenkins to kick off gating jobs
> (https://review.openstack.org/#/c/13962/). Not saying that the patch is bad
> in any way, but it just seems like time to let more eyes on things is a good
> thing.
> 
> 7 minutes is often shorter than the time it takes to get the notification
> emails.
> 
> Was there previously a convention on minimum review time? I vaguely
> remember a similar conversation when Folsom opened up.
> 
> 	-Sean
> 
> --
> Sean Dague
> IBM Linux Technology Center
> email: sdague at linux.vnet.ibm.com
> alt-email: sldague at us.ibm.com
> 
> 
> _______________________________________________
> OpenStack-dev mailing list
> OpenStack-dev at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev