<div dir="ltr">:-( Apparently I'm not doing so great at reply-to-list these days<br><br><div class="gmail_quote">---------- Forwarded message ----------<br>From: <b class="gmail_sendername">Mark Washenberger</b> <span dir="ltr"><<a href="mailto:mark.washenberger@markwash.net">mark.washenberger@markwash.net</a>></span><br>
Date: Thu, May 2, 2013 at 12:33 AM<br>Subject: Re: [openstack-tc] Copyrights and License Headers in source files<br>To: Mark McLoughlin <<a href="mailto:markmc@redhat.com">markmc@redhat.com</a>><br><br><br><div dir="ltr">
<br><div class="gmail_extra"><br><br><div class="gmail_quote"><div class="im">On Wed, May 1, 2013 at 10:53 PM, Mark McLoughlin <span dir="ltr"><<a href="mailto:markmc@redhat.com" target="_blank">markmc@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hi Mark,<br>
<div><br>
On Wed, 2013-05-01 at 14:57 -0700, Mark Washenberger wrote:<br>
> Hi folks,<br>
><br>
> I was looking into the ASL-2.0, and chanced across the fact that in Apache<br>
> projects, they require that source files only have the License Header, and<br>
> may not have any copyright notices [1]. It occurred to me that we waste a<br>
> fair amount of time on copyrights in license headers, and it would be nice<br>
> not to have to do that anymore.<br>
<br>
</div>Like Monty said, I'd like to hear more about why these are seen as a<br>
time sink.<br></blockquote><div><br></div></div><div>I'm having a difficult time providing hard numbers for you. I think one way to check for this would be to grep gerrit review notes, but I don't know how to do that. But in a non-exhaustive search, I can see some examples</div>
<div><br></div><div><a href="https://review.openstack.org/#/c/27001/" target="_blank">https://review.openstack.org/#/c/27001/</a> -> headers were missing from empty files, caught in review (eventually)<br></div><div>
<a href="https://review.openstack.org/#/c/23044/" target="_blank">https://review.openstack.org/#/c/23044/</a> -> copyright had wrong year (caught in review)<br></div><div><a href="https://review.openstack.org/#/c/22742/" target="_blank">https://review.openstack.org/#/c/22742/</a> -> just my fault, but I misunderstood the copyright policy and got someone to change to "Openstack Foundation" from their company<br>
</div><div><a href="https://review.openstack.org/#/c/20927/" target="_blank">https://review.openstack.org/#/c/20927/</a> -> wrong year (caught in review)<br></div><div><a href="https://review.openstack.org/#/c/20926/" target="_blank">https://review.openstack.org/#/c/20926/</a> -> wrong year (caught in review)<br>
</div><div><a href="https://review.openstack.org/#/c/20925/" target="_blank">https://review.openstack.org/#/c/20925/</a> -> wrong year (caught in review)<br></div><div><a href="https://review.openstack.org/#/c/20914" target="_blank">https://review.openstack.org/#/c/20914</a> -> should be "Foundation" not "LLC", not caught in review<br>
</div><div><a href="https://review.openstack.org/#/c/21130" target="_blank">https://review.openstack.org/#/c/21130</a> -> s/LLC/Foundation/ not caught in review<br></div><div><br></div><div>I found these by manually inspecting only the latest 13 results I got when I searched for commits in glance that add files.</div>
<div><br></div><div>From this data, I think its clear that coders are making mistakes about licensing/copyright headers, and reviewers are having to pause to think about the correctness of those headers.</div>
<div><br></div><div>While the amount of effort here isn't necessarily very large, I'd like to draw your attention to the amount of effort that it probably should be: 0. In proportional terms, we're pretty far away from ideal :-)</div>
<div class="im">
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div><br>
> I also noticed a previous conversation [2] on this subject. I have not<br>
> found any policy that actually requires us to include copyrights with each<br>
> source file license header.<br>
><br>
> Feel free to suggest that this is more trouble than it is worth, but I'd<br>
> like to propose that we discourage new contributions from including<br>
> copyright attribution, and provide a process to work with the various<br>
> parties we have to remove the copyrights from existing files.<br>
<br>
</div>I don't have a massively strong opinion on this and I'd never really<br>
considered the possibility of not having copyright headers, but my first<br>
thought is that I like that we have them. I like that "ownership" of the<br>
work is distributed and it's nice to be able to see how that ownership<br>
is distributed through the code base.<br></blockquote><div><br></div></div><div>I'd never considered it either, until I found out that Apache Software Foundation projects are explicitly required to *not* put copyright headers in their source files (they do, however, retain license headers). I realize that rule doesn't apply to us, but if it's good enough for ASF, how are we different?</div>
<div><br></div><div>I'd also contend that the view of ownership you get from looking at copyright headers is pretty inaccurate. For example (again from Glance), </div><div><br></div><div><div>$ git grep -i rackspace | grep -i copyright | wc -l</div>
<div> 0</div><div><br></div><div><br></div></div><div class="im"><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
In any case, I think it's too late for us to effectively make a change<br>
in like this successfully and not worth the hassle.<br></blockquote><div><br></div></div><div>I would agree if I thought that such a change required any of the following:</div><div> 1) changing existing copyright headers</div>
<div> 2) changing the CLA</div><div> 3) changing bylaws</div><div><br></div><div>But I don't think those are needed. If we simply said "stop adding copyright headers", then I believe I could write a flake8 hacking rule to check for correct license headers (sans copyright) on new files. That would be enough for me, because my goal here is for people to not have to think about such headers during future development and review.</div>
<div><br></div></div></div></div>
</div><br></div>