Open Stack

Good explanation Catherine!   So as she described: a change in the test name (or path) *does* affect us, but it’s generally super easy for us to deal with and IMHO shouldn’t be an issue that holds up refactoring.  Basically we just add an alias to the Guideline's JSON files when a test changes and it’s taken care of.  It’s helpful if we can get a heads-up if a test’s name is changing so we can add the alias before folks trying to get a trademark/logo license agreement from the Foundation run into problems, but in the event something slips through it’s a pretty trivial fix that we can merge quickly.

At Your Service,

Mark T. Voelker



> On Mar 18, 2016, at 2:09 AM, Catherine Cuong Diep <cdiep at us.ibm.com> wrote:
> 
> Hi Ken,
> 
> DefCore test list is using full test path name and not idempotent_id due to the issue reported in https://bugs.launchpad.net/tempest/+bug/1433700 . As such, any change in the path name or test name will affect the test list. Currently, DefCore uses "alias" to identify tests with same idempotent_id . Please see alias description in http://git.openstack.org/cgit/openstack/defcore/tree/doc/source/schema/1.4.rst#n82 
> 
> Catherine Diep
> IBM Silicon Valley Laboratory, San Jose, California 95141
> cdiep at us.ibm.com, Tel: (408) 463-4352 T/L: 543-4352
> ----- Forwarded by Catherine Cuong Diep/San Jose/IBM on 03/17/2016 09:25 PM -----
> 
> From: "Ken'ichi Ohmichi" <ken1ohmichi at gmail.com>
> To: Mark Voelker <mvoelker at vmware.com>
> Cc: "defcore-committee at lists.openstack.org" <defcore-committee at lists.openstack.org>
> Date: 03/17/2016 07:25 PM
> Subject: [OpenStack-DefCore] Is it fine to change test paths of Tempest? (Re: [openstack-dev] [QA][all] Propose to remove negative tests from Tempest)
> 
> 
> 
> 
> Hi Mark,
> 
> Thanks for sharing it on Defcore committee :-)
> 
> That is off-topic from the original discussion, but I'd like to ask a
> question between Tempest and Defcore.
> 
> The link[1] as you pointed contains test paths of Tempest like
> tempest.api.compute.test_authorization.AuthorizationTestJSON.test_create_server_fails_when_tenant_incorrect
> 
> Is it acceptable to change these paths from Defcore viewpoint?
> 
> [1] contains idempotent_id also which is tagged for each test and
> Tempest consumers would be able to use the id instead of the path.
> So it seems possible to change the paths in general and sometimes
> people propose changing paths for correct ones.
> For example, AuthorizationTestJSON could be changed to
> AuthorizationTest by removing JSON because now opposite(XML) tests
> don't exist in Tempest.
> 
> If such change is fine from Defcore viewpoint also, I can agree
> confidently with these changes.
> 
> Thanks
> 
> ---
> [1] http://git.openstack.org/cgit/openstack/defcore/tree/2016.01.json
> 
> 2016-03-17 9:20 GMT-07:00 Mark Voelker <mvoelker at vmware.com>:
> > FYI for DefCore folks that might wish to contribute to the discussion as there are ~118 negative tests included in the most recent Board-approved DefCore Guideline.  [1]
> >
> > We discussed negative tests included in the DefCore Guidelines a bit in the past and general consensus has been that it’s reasonable to include negative tests for a Capability since it validates that the “unhappy path” works in an interoperable way just as the “happy path” for an action does.  Note that the suggestion here is to move negative tests to the Tempest plugin interface.  As we’ve discussed, DefCore can accept in-project-tree tests via the Tempest plugin interface and RefStack will able to run them.  Therefore I think if this plan is implemented, it should be mostly non-impacting for us: we can continue including the negative tests we have today, though we may need to do some housekeeping as tests move around (so we should probably keep an eye on the review queues…it would be super helpful to have a heads-up from reviewers on those patches if possible, but we’ll probably find them either way =).
> >
> > [1] http://git.openstack.org/cgit/openstack/defcore/tree/2016.01.json
> >
> > At Your Service,
> >
> > Mark T. Voelker
> >
> >
> >
> >
> >> Begin forwarded message:
> >>
> >> From: "Ken'ichi Ohmichi" <ken1ohmichi at gmail.com>
> >> Subject: [openstack-dev] [QA][all] Propose to remove negative tests from Tempest
> >> Date: March 16, 2016 at 9:20:11 PM EDT
> >> To: OpenStack Development Mailing List <openstack-dev at lists.openstack.org>
> >> Reply-To: "OpenStack Development Mailing List (not for usage questions)" <openstack-dev at lists.openstack.org>
> >>
> >> Hi
> >>
> >> I have one proposal[1] related to negative tests in Tempest, and
> >> hoping opinions before doing that.
> >>
> >> Now Tempest contains negative tests and sometimes patches are being
> >> posted for adding more negative tests, but I'd like to propose
> >> removing them from Tempest instead.
> >>
> >> Negative tests verify surfaces of REST APIs for each component without
> >> any integrations between components. That doesn't seem integration
> >> tests which are scope of Tempest.
> >> In addition, we need to spend the test operating time on different
> >> component's gate if adding negative tests into Tempest. For example,
> >> we are operating negative tests of Keystone and more
> >> components on the gate of Nova. That is meaningless, so we need to
> >> avoid more negative tests into Tempest now.
> >>
> >> If wanting to add negative tests, it is a nice option to implement
> >> these tests on each component repo with Tempest plugin interface. We
> >> can avoid operating negative tests on different component gates and
> >> each component team can decide what negative tests are valuable on the
> >> gate.
> >>
> >> In long term, all negative tests will be migrated into each component
> >> repo with Tempest plugin interface. We will be able to operate
> >> valuable negative tests only on each gate.
> >>
> >> Any thoughts?
> >>
> >> Thanks
> >> Ken Ohmichi
> >>
> >> ---
> >> [1]: https://review.openstack.org/#/c/293197/
> >>
> >> __________________________________________________________________________
> >> OpenStack Development Mailing List (not for usage questions)
> >> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
> 
> _______________________________________________
> Defcore-committee mailing list
> Defcore-committee at lists.openstack.org
> http://lists.openstack.org/cgi-bin/mailman/listinfo/defcore-committee
>